Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1341934
| From | Sebastian Ott <sebott@linux.vnet.ibm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) |
| Date | 2016-02-24 13:20 +0100 |
| Message-ID | <r5GAa-4oo-17@gated-at.bofh.it> (permalink) |
| References | (5 earlier) <r1pxW-1vA-55@gated-at.bofh.it> <r5k6C-5fs-17@gated-at.bofh.it> <r5pJ1-G1-25@gated-at.bofh.it> <r5rKO-24m-35@gated-at.bofh.it> <r5D9f-1Oq-3@gated-at.bofh.it> |
| Organization | "IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294" |
On Wed, 24 Feb 2016, Martin Schwidefsky wrote:
> On Tue, 23 Feb 2016 22:33:45 +0300
> "Kirill A. Shutemov" <kirill@shutemov.name> wrote:
>
> > On Tue, Feb 23, 2016 at 07:19:07PM +0100, Gerald Schaefer wrote:
> > > I'll check with Martin, maybe it is actually trivial, then we can
> > > do a quick test it to rule that one out.
> >
> > Oh. I found a bug in __split_huge_pmd_locked(). Although, not sure if it's
> > _the_ bug.
> >
> > pmdp_invalidate() is called for the wrong address :-/
> > I guess that can be destructive on the architecture, right?
> >
> > Could you check this?
> >
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index 1c317b85ea7d..4246bc70e55a 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -2865,7 +2865,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> > pgtable = pgtable_trans_huge_withdraw(mm, pmd);
> > pmd_populate(mm, &_pmd, pgtable);
> >
> > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) {
> > + for (i = 0; i < HPAGE_PMD_NR; i++) {
> > pte_t entry, *pte;
> > /*
> > * Note that NUMA hinting access restrictions are not
> > @@ -2886,9 +2886,9 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> > }
> > if (dirty)
> > SetPageDirty(page + i);
> > - pte = pte_offset_map(&_pmd, haddr);
> > + pte = pte_offset_map(&_pmd, haddr + i * PAGE_SIZE);
> > BUG_ON(!pte_none(*pte));
> > - set_pte_at(mm, haddr, pte, entry);
> > + set_pte_at(mm, haddr + i * PAGE_SIZE, pte, entry);
> > atomic_inc(&page[i]._mapcount);
> > pte_unmap(pte);
> > }
> > @@ -2938,7 +2938,7 @@ static void __split_huge_pmd_locked(struct vm_area_struct *vma, pmd_t *pmd,
> > pmd_populate(mm, pmd, pgtable);
> >
> > if (freeze) {
> > - for (i = 0; i < HPAGE_PMD_NR; i++, haddr += PAGE_SIZE) {
> > + for (i = 0; i < HPAGE_PMD_NR; i++) {
> > page_remove_rmap(page + i, false);
> > put_page(page + i);
> > }
>
> Test is running and it looks good so far. For the final assessment I defer
> to Gerald and Sebastian.
>
Yes, that one worked. My testsystem is doing make -j10 && make clean
in a loop since 4 hours now. Thanks!
Sebastian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-23 13:20 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Linus Torvalds <torvalds@linux-foundation.org> - 2016-02-23 18:50 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Gerald Schaefer <gerald.schaefer@de.ibm.com> - 2016-02-23 19:20 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Will Deacon <will.deacon@arm.com> - 2016-02-23 19:50 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Steve Capper <steve.capper@linaro.org> - 2016-02-25 16:50 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-25 17:10 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Steve Capper <steve.capper@linaro.org> - 2016-02-25 17:10 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Will Deacon <will.deacon@arm.com> - 2016-02-23 21:30 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Christian Borntraeger <borntraeger@de.ibm.com> - 2016-02-24 11:20 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Will Deacon <will.deacon@arm.com> - 2016-02-24 11:50 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Christian Borntraeger <borntraeger@de.ibm.com> - 2016-02-24 12:00 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Will Deacon <will.deacon@arm.com> - 2016-02-24 12:10 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com> - 2016-02-24 18:30 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-02-24 09:30 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-02-24 09:40 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Sebastian Ott <sebott@linux.vnet.ibm.com> - 2016-02-24 13:20 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-24 10:20 +0100
Re: [BUG] random kernel crashes after THP rework on s390 (maybe also on PowerPC and ARM) Gerald Schaefer <gerald.schaefer@de.ibm.com> - 2016-02-24 17:50 +0100
csiph-web