Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1341920
| From | Borislav Petkov <bp@alien8.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address |
| Date | 2016-02-24 12:40 +0100 |
| Message-ID | <r5FXr-3Sa-1@gated-at.bofh.it> (permalink) |
| References | <r2VvH-530-5@gated-at.bofh.it> <r2VvI-530-25@gated-at.bofh.it> <r5kpY-5q1-9@gated-at.bofh.it> <r5u5Y-3KD-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote:
> I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well.
> So might be better to retain it here.
Actually, I'm thinking, these all are - even if used in multiple files
- all MCE-specific and therefore used in MCE/RAS-specific code. So they
all should go into mce.h. Everything RAS includes that header so they're
perfectly fine there...
> (It comes up to 81 chars, but will ignore checkpatch in this case..)
The 80-cols rule is not a hard one. Here's some food for thought:
https://lkml.kernel.org/r/20160219095132.GA9681@gmail.com
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address Borislav Petkov <bp@alien8.de> - 2016-02-23 13:40 +0100
Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com> - 2016-02-24 00:00 +0100
Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address Borislav Petkov <bp@alien8.de> - 2016-02-24 12:40 +0100
Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address Boris Petkov <bp@alien8.de> - 2016-02-24 21:40 +0100
csiph-web