Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1341904

[PATCH v2] osd: remove deadcode

Show all headers | View raw

The variable is_ver1 is always true and so OSD_CAP_LEN can never be
used.
Reported by Coverity.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
---

v2: Joe Perches asked to mention the tool used in the commit log.

 drivers/scsi/osd/osd_initiator.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/scsi/osd/osd_initiator.c b/drivers/scsi/osd/osd_initiator.c
index d8a2b51..3b11aad 100644
--- a/drivers/scsi/osd/osd_initiator.c
+++ b/drivers/scsi/osd/osd_initiator.c
@@ -2006,9 +2006,8 @@ EXPORT_SYMBOL(osd_sec_init_nosec_doall_caps);
  */
 void osd_set_caps(struct osd_cdb *cdb, const void *caps)
 {
-	bool is_ver1 = true;
 	/* NOTE: They start at same address */
-	memcpy(&cdb->v1.caps, caps, is_ver1 ? OSDv1_CAP_LEN : OSD_CAP_LEN);
+	memcpy(&cdb->v1.caps, caps, OSDv1_CAP_LEN);
 }
 
 bool osd_is_sec_alldata(struct osd_security_parameters *sec_parms __unused)
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] osd: remove deadcode Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-24 12:30 +0100
  Re: [PATCH v2] osd: remove deadcode "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> - 2016-02-24 14:50 +0100
  Re: [PATCH v2] osd: remove deadcode Boaz Harrosh <ooo@electrozaur.com> - 2016-02-24 16:00 +0100
  Re: [PATCH v2] osd: remove deadcode "Martin K. Petersen" <martin.petersen@oracle.com> - 2016-02-26 03:20 +0100

csiph-web