Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1341780

Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow handling

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow handling
Date 2016-02-24 11:40 +0100
Message-ID <r5F1o-3ab-1@gated-at.bofh.it> (permalink)
References <r0NVE-1Am-7@gated-at.bofh.it> <r0O5k-1E8-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 10 Feb 2016, Vikas Shivappa wrote:
> +static enum hrtimer_restart mbm_hrtimer_handle(struct hrtimer *hrtimer)
> +{
> +	if (list_empty(&cache_groups))
> +		goto out;
> +
> +	list_for_each_entry(iter, &cache_groups, hw.cqm_groups_entry) {

....

> +		}
> +	}
> +
> +out:
> +	raw_spin_unlock_irqrestore(&cache_lock, flags);
> +	mutex_unlock(&cache_mutex);
> +
> +	hrtimer_forward_now(hrtimer, ms_to_ktime(MBM_CTR_OVERFLOW_TIME));
> +
> +	return HRTIMER_RESTART;

Why is that timer restarted if cache_groups is empty?

Thanks,

	tglx

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow  handling Thomas Gleixner <tglx@linutronix.de> - 2016-02-24 11:40 +0100
  Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow  handling Vikas Shivappa <vikas.shivappa@intel.com> - 2016-02-24 19:20 +0100
    Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow  handling Thomas Gleixner <tglx@linutronix.de> - 2016-02-24 20:30 +0100

csiph-web