Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340091

Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer

Show all headers | View raw

Hi,

On 22 February 2016 at 23:28, David Howells <dhowells@redhat.com> wrote:
> Tadeusz Struk <tadeusz.struk@intel.com> wrote:
>
>> I wonder if this should be merged with the crypto/rsa-pkcs1pad.c template
>> that we already have. Looks like the two do the same padding now.

I think that'd be a good thing to do.

>> Should we merge then and pass the hash param as a separate template param,
>> e.g the public_key would allocate "pkcs1pad(rsa, sha1)"?
>
> Ummm...  Possibly.  Is that how it's used?

Currently it only does the padding and doesn't care about the hash.
The input is expected to be the entire DigestInfo struct.

AIUI Tadeusz is proposing adding the hashing as a new feature.  Note
though that the hash paremeter won't make sense for the encrypt,
decrypt or verify operations.

Also note that TLS 1.0 uses the padding to sign data that is not a
DigestInfo structure and even for 1.2 there are situations where
you'll be hashing the data yourself over some time and then you'll
want the algorithm to only do the padding and RSA signing.

Cheers

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] X.509: Software public key subtype changes David Howells <dhowells@redhat.com> - 2016-02-19 18:20 +0100
  [PATCH 6/8] X.509: Make the public_key asymmetric key type internal  data private David Howells <dhowells@redhat.com> - 2016-02-19 18:20 +0100
  [PATCH 1/8] crypto: KEYS: convert public key and digsig asym to the  akcipher api David Howells <dhowells@redhat.com> - 2016-02-19 18:20 +0100
  [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer David Howells <dhowells@redhat.com> - 2016-02-19 18:30 +0100
    Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto  layer Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-22 21:10 +0100
      Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer David Howells <dhowells@redhat.com> - 2016-02-22 23:30 +0100
        Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto  layer Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-23 00:40 +0100
          Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer David Howells <dhowells@redhat.com> - 2016-02-23 12:00 +0100
            [PATCH 0/2] KEYS: Use pkcs1pad for padding in software_pkey Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-24 18:20 +0100
              Re: [PATCH 0/2] KEYS: Use pkcs1pad for padding in software_pkey David Howells <dhowells@redhat.com> - 2016-02-24 18:30 +0100
        Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer Andrew Zaborowski <balrogg@googlemail.com> - 2016-02-23 01:10 +0100
          Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer David Howells <dhowells@redhat.com> - 2016-02-23 12:00 +0100
            Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer Andrew Zaborowski <balrogg@googlemail.com> - 2016-02-23 12:30 +0100
              Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer David Howells <dhowells@redhat.com> - 2016-02-26 12:50 +0100
    Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto  layer Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-24 06:10 +0100
      Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto  layer Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-24 07:10 +0100
        Re: [PATCH 4/8] akcipher: Move the RSA DER encoding to the crypto layer David Howells <dhowells@redhat.com> - 2016-02-29 16:40 +0100
  [PATCH 7/8] X.509: Rename public_key.c to software_pkey.c David Howells <dhowells@redhat.com> - 2016-02-19 18:30 +0100
  [PATCH 5/8] X.509: Make algo identifiers text instead of enum David Howells <dhowells@redhat.com> - 2016-02-19 18:30 +0100
  [PATCH 8/8] X.509: Rename public_key* to software_pkey* David Howells <dhowells@redhat.com> - 2016-02-19 18:30 +0100
  Re: [PATCH 0/8] X.509: Software public key subtype changes Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-22 20:00 +0100
    Re: [PATCH 0/8] X.509: Software public key subtype changes David Howells <dhowells@redhat.com> - 2016-02-22 23:30 +0100
      Re: [PATCH 0/8] X.509: Software public key subtype changes Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-23 01:10 +0100
        Re: [PATCH 0/8] X.509: Software public key subtype changes David Howells <dhowells@redhat.com> - 2016-02-23 11:20 +0100
          Re: [PATCH 0/8] X.509: Software public key subtype changes Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-23 13:30 +0100
  Re: [PATCH 0/8] X.509: Software public key subtype changes Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-22 21:10 +0100

csiph-web