Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1340020

Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES

From Yu-cheng Yu <yu-cheng.yu@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES
Date 2016-02-22 23:40 +0100
Message-ID <r57j4-4kk-7@gated-at.bofh.it> (permalink)
References <r541P-1YW-7@gated-at.bofh.it> <r54XU-2FL-9@gated-at.bofh.it> <r55Kj-2Wr-23@gated-at.bofh.it> <r56ZI-44s-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 22, 2016 at 02:19:05PM -0800, Dave Hansen wrote:
> On 02/22/2016 12:48 PM, Yu-cheng Yu wrote:
> > It should have been:
> > 
> > 	xsave->header.xfeatures = xfeatures |
> > 		(xsave->header.xfeatures & XFEATURE_MASK_SUPERVISOR);
> > 
> > I'll fix it.
> 
> Can we break it out to make it more clear?
> 
> /*
>  * The state that came in from userspace was user-state only.
>  * Mask all the user states out of 'xfeatures'.
>  */
> xsave->header.xfeatures &= XFEATURE_MASK_SUPERVISOR;
> /*
>  * add back in the features that came in from userspace
>  */
> xsave->header.xfeatures |= xfeatures

I will update it in the next version. Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-02-22 20:10 +0100
  Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-02-22 21:10 +0100
    Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-02-22 22:00 +0100
      Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-02-22 23:20 +0100
        Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-02-22 23:40 +0100
  Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Andy Lutomirski <luto@amacapital.net> - 2016-02-22 23:50 +0100
    Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Andy Lutomirski <luto@amacapital.net> - 2016-02-23 00:00 +0100
    Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Yu-cheng Yu <yu-cheng.yu@intel.com> - 2016-02-23 00:00 +0100
    Re: [PATCH 08/10] x86/xsaves: Fix PTRACE frames for XSAVES Dave Hansen <dave.hansen@linux.intel.com> - 2016-02-23 00:00 +0100

csiph-web