Re: [PATCH] irqchip: irq-mvebu-odmi: new driver

From	Rob Herring <robh@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] irqchip: irq-mvebu-odmi: new driver
Date	2016-02-22 20:20 +0100
Message-ID	<r54bv-23H-7@gated-at.bofh.it> (permalink)
References	<r2m4X-6kq-15@gated-at.bofh.it> <r4OT8-7hh-33@gated-at.bofh.it> <r4TSP-2Pd-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 22, 2016 at 2:10 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> FWIW, you're replying to the v1 of this patch, while v2 and v3 have
> already been posted, and v3 has already been merged by the irqchip
> maintainers:
>
>   http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=c27f29bbbf02168c9b1e8ba0fe7a8cb917e5a50f

Well, that's what you get when I'm working offline for a bit. :)

> On Sun, 21 Feb 2016 20:53:53 -0600, Rob Herring wrote:
>
>> > +- compatible              : The value here should contain "marvell,odmi-controller".
>>
>> SoC specific compatible too please.
>
> I can add that in a follow-up patch.

Please do.

>
>> > +- marvell,spi-base     : List of GIC base SPI interrupts, one for each
>> > +                         ODMI frame.
>>
>> Why not "interrupts" property?
>
> This has already been discussed with Arnd in a more recent iteration of
> the patch:
>
>   http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409411.html
>   http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409415.html
>   http://lists.infradead.org/pipermail/linux-arm-kernel/2016-February/409430.html

Okay, it's fine.

Rob

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] irqchip: irq-mvebu-odmi: new driver Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-15 08:50 +0100
  Re: [PATCH] irqchip: irq-mvebu-odmi: new driver Marc Zyngier <marc.zyngier@arm.com> - 2016-02-15 10:20 +0100
  Re: [PATCH] irqchip: irq-mvebu-odmi: new driver Rob Herring <robh@kernel.org> - 2016-02-22 04:00 +0100
    Re: [PATCH] irqchip: irq-mvebu-odmi: new driver Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2016-02-22 09:20 +0100
      Re: [PATCH] irqchip: irq-mvebu-odmi: new driver Rob Herring <robh@kernel.org> - 2016-02-22 20:20 +0100

csiph-web