Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1339838

Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5

From Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5
Date 2016-02-22 20:10 +0100
Message-ID <r541Q-1YW-29@gated-at.bofh.it> (permalink)
References <r4aVH-2bU-5@gated-at.bofh.it> <r4NX4-6FN-19@gated-at.bofh.it> <r507U-7eO-25@gated-at.bofh.it> <r52W6-YY-9@gated-at.bofh.it>
Organization Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw


On Mon, Feb 22, 2016 at 10:52:45AM -0700, Jason Gunthorpe wrote:
> On Mon, Feb 22, 2016 at 04:50:23PM +0200, Jarkko Sakkinen wrote:
> 
> > I already pushed a fix to my master for this issue:
> > 
> > https://github.com/jsakkine/linux-tpmdd/commit/6386544ad7bceb3d0248b85da29d4d99eebe9161
> 
> The goal is to reduce the number of #ifdef'd code segments so we have
> fewer problems in future with a large .config test matrix.
> 
> I'd rather see a __maybe_unused annotation instead.

Agreed that it's a better form but at this point it's probably revert
the breaking change and move to that later on. Otherwise, I don't see
reason not to include the patch that you authored to the release. I've
used it in my test kernels for quite some time now and it has worked
without issues.

I sent my fix for review now.

> Jason

/Jarkko

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-20 09:20 +0100
  Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 James Morris <jmorris@namei.org> - 2016-02-22 03:00 +0100
    Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-22 16:00 +0100
      Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-22 19:00 +0100
        Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-22 20:10 +0100
          Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-02-22 20:20 +0100
            Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-22 22:30 +0100
      Re: [tpmdd-devel] [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jerry Snitselaar <jsnitsel@redhat.com> - 2016-02-25 18:40 +0100
        Re: [tpmdd-devel] [GIT PULL] remaining tpmdd fixes for Linux 4.5 James Morris <jmorris@namei.org> - 2016-02-26 04:40 +0100
          Re: [tpmdd-devel] [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-26 10:50 +0100
      Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 James Morris <jmorris@namei.org> - 2016-02-26 09:00 +0100
        Re: [GIT PULL] remaining tpmdd fixes for Linux 4.5 Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-02-26 10:10 +0100

csiph-web