Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339812

Re: [patch V2 28/28] x86/perf/intel/rapl: Make it modular

Show all headers | View raw

Thomas Gleixner <tglx@linutronix.de> writes:

> Add the necessary exit functions so it can be built as a module.

If you make it a module you also need to add MODULE_DEVICE_TABLE
for the PCI IDs and also add x86_cpu_id tables/annotations
for the model numbers.

Otherwise the module would always need to be loaded manually
which would break existing setups.

Of course it's a bit of a waste because in many cases the uncore
driver will not be needed. One alternative would be to only
add some module aliases and then add code in the perf core
to probe the alias when that PMU is accessed. That would
likely work for most of perf, except for perf list (which does
not know what pmu to probe)

Other than that it's very useful, it was long overdue to make
these drivers modular.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[patch V2 28/28] x86/perf/intel/rapl: Make it modular Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 12:10 +0100
  Re: [patch V2 28/28] x86/perf/intel/rapl: Make it modular Andi Kleen <andi@firstfloor.org> - 2016-02-22 19:50 +0100
    Re: [patch V2 28/28] x86/perf/intel/rapl: Make it modular Thomas Gleixner <tglx@linutronix.de> - 2016-02-22 20:20 +0100

csiph-web