Re: [PATCH v2 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.

Path	csiph.com!news.mixmin.net!border2.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	Russell King - ARM Linux <linux@arm.linux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/2] drm: Improve drm_of_component_probe() to correctly handle ports and remote ports.
Date	Mon, 22 Feb 2016 17:00:02 +0100
Message-ID	<r513Y-7RT-3@gated-at.bofh.it> (permalink)
References	<qwURj-8na-15@gated-at.bofh.it> <qwURk-8na-21@gated-at.bofh.it> <r4XjJ-5i9-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=arm.linux.org.uk; s=pandora-2014; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=QJ89sNQWVFdaZbzoY6TK7kU+I6zY7ReVwEHmxfHf1Ug=; b=gYVWIt4Tas7mwz6tl9hSAzl7EYLrqhCC7gbGaPxqfbOIdqsMLiMa9a+znIfIbx+TTRRi28Vo5C7XWA6hqFiLmQ8+zVh5lNaDjGWkmO4hKKIMYNNkoV6LfDb1KnXh8Ft+E6CMiW77csFHqJkA2wbBkkQ29bolTr+xd8FEtUwUXZk=;
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Mark Yao <mark.yao@rock-chips.com>, Heiko Stübner <heiko@sntech.de>, Philipp Zabel <p.zabel@pengutronix.de>, Daniel Vetter <daniel.vetter@ffwll.ch>, David Airlie <airlied@linux.ie>, Eric Anholt <eric@anholt.net>, linux-rockchip <linux-rockchip@lists.infradead.org>, LAKML <linux-arm-kernel@lists.infradead.org>, dri-devel <dri-devel@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 22 Feb 2016 15:51:29 +0000
X-Original-Message-ID	<20160222155128.GE19428@n2100.arm.linux.org.uk>
X-Original-References	<1448029325-14602-1-git-send-email-Liviu.Dudau@arm.com> <1448029325-14602-2-git-send-email-Liviu.Dudau@arm.com> <20160222115147.GR1123@e106497-lin.cambridge.arm.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1339670

Show key headers only | View raw

On Mon, Feb 22, 2016 at 11:51:47AM +0000, Liviu Dudau wrote:
> On Fri, Nov 20, 2015 at 02:22:04PM +0000, Liviu Dudau wrote:
> > Rockchip DRM driver cannot use the same compare_of() function to
> > match ports and remote ports (aka encoders) as their OF sub-trees
> > look different. Add a second compare function to be used when encoders
> > are added to the component framework and patch the existing users of
> > the function accordingly.
> > 
> > Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>
> 
> Russell,
> 
> Resurecting this old patch from around Christmas time (bad time for patch
> review).
> 
> Are you happy enough with this version to re-issue the Ack or do you think
> I still need to work on it?

What I'd like to see is the patch reworked, because:

> > +		component_match_add(dev, &match, compare_port, port);
> > +		/*
> > +		 * component_match_add keeps a reference to the port
> > +		 * variable, so we need to keep the reference count
> > +		 * increment from of_parse_phandle()
> > +		 */
...
> > +			component_match_add(dev, &match, compare_encoder, remote);
> > +			/*
> > +			 * component_match_add keeps a reference to the port
> > +			 * variable, so we need to keep the reference count
> > +			 * increment from of_graph_get_remote_port_parent()
> > +			 */

This problem no longer exists.

-- 
RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Thread

Re: [PATCH v2 1/2] drm: Improve drm_of_component_probe() to  correctly handle ports and remote ports. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-02-22 13:00 +0100
  Re: [PATCH v2 1/2] drm: Improve drm_of_component_probe() to  correctly handle ports and remote ports. Russell King - ARM Linux <linux@arm.linux.org.uk> - 2016-02-22 17:00 +0100
    Re: [PATCH v2 1/2] drm: Improve drm_of_component_probe() to  correctly handle ports and remote ports. Liviu Dudau <Liviu.Dudau@arm.com> - 2016-02-22 17:00 +0100

csiph-web