Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339649

Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree

Show all headers | View raw

On Monday 22 February 2016 10:53:11 Anurag Kumar Vulisha wrote:
> > >
> > 
> > How would a hardware integrator know which value is right for a particular
> > SoC?
> > 
> > Could it be keyed off the hardware ID? Could the bootloader perhaps set an
> > appropriate value in the AHCI_VEND_PTC register at boot time and the driver
> > read the initial value from it?
> > 
> > From the description, it sounds like this is a policy decision rather than
> > hardware description, and shouldn't really be in here.
> > 
> 
> Thanks for reviewing the patch. Can I use module_param() for this watermark instead of reading it from devicetree or
> doing it in bootloader. In bootloader we are initializing serdes controller for high speed devices. As a part of this initialization
> we will be reseting all the high speed pheripherals which are using serdes, so SATA will also get resetted. Because of this
> reason, can I use module_param() for Rxwatermark value  instead?
> 

I don't know what is appropriate because I have no idea what Rxwatermark
is good for. Can you try describing why we can't just set it to the
correct value for everyone automatically?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> - 2016-02-20 14:40 +0100
  Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Arnd Bergmann <arnd@arndb.de> - 2016-02-20 23:40 +0100
    RE: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> - 2016-02-22 12:10 +0100
      Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Arnd Bergmann <arnd@arndb.de> - 2016-02-22 16:30 +0100
        RE: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> - 2016-02-23 07:20 +0100
          Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Arnd Bergmann <arnd@arndb.de> - 2016-02-23 11:30 +0100
            RE: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> - 2016-02-23 16:40 +0100
              Re: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Rob Herring <robh@kernel.org> - 2016-02-23 20:30 +0100
                RE: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> - 2016-02-26 14:50 +0100
                RE: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com> - 2016-03-02 07:10 +0100
                Re: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Michal Simek <michal.simek@xilinx.com> - 2016-03-02 09:10 +0100
                Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Arnd Bergmann <arnd@arndb.de> - 2016-03-02 10:20 +0100
                Re: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Michal Simek <michal.simek@xilinx.com> - 2016-03-02 10:30 +0100
                Re: [RFC PATCH] drivers: ata: Read Rx water mark value from device-tree Arnd Bergmann <arnd@arndb.de> - 2016-03-02 12:50 +0100
                Re: [RFC PATCH] drivers: ata: Read Rx water mark value from  device-tree Michal Simek <michal.simek@xilinx.com> - 2016-03-02 13:10 +0100

csiph-web