Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1339574
| From | Boris Ostrovsky <boris.ostrovsky@oracle.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check |
| Date | 2016-02-22 15:40 +0100 |
| Message-ID | <r4ZOy-77E-35@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <r3SYP-5z8-25@gated-at.bofh.it> <r3Tia-5GH-13@gated-at.bofh.it> <r3UxA-6tl-1@gated-at.bofh.it> <r4RR0-1mE-3@gated-at.bofh.it> <r4VUC-4ex-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 02/22/2016 05:27 AM, Borislav Petkov wrote:
> On Mon, Feb 22, 2016 at 07:07:56AM +0100, Luis R. Rodriguez wrote:
>> diff --git a/arch/x86/include/asm/x86_init.h b/arch/x86/include/asm/x86_init.h
>> index 1ae89a2721d6..fe0d579b63e3 100644
>> --- a/arch/x86/include/asm/x86_init.h
>> +++ b/arch/x86/include/asm/x86_init.h
>> @@ -84,11 +84,14 @@ struct x86_init_paging {
>> * boot cpu
>> * @timer_init: initialize the platform timer (default PIT/HPET)
>> * @wallclock_init: init the wallclock device
>> + * @no_cmos_rtc: set when platform has no CMOS real-time clock
>> + * present
>> */
>> struct x86_init_timers {
>> void (*setup_percpu_clockev)(void);
>> void (*timer_init)(void);
>> void (*wallclock_init)(void);
>> + bool no_cmos_rtc;
> I'd add
>
> u64 flags;
>
> to x86_init_ops and then set X86_PLATFORM_NO_RTC or so in there. The
> reason being, others could use that flags field too, for other stuff and
> define more bits.
Maybe timer_flags or platform_flags (or something else) to be a little
more cscope-friendly?
-boris
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/9] x86/init: replace paravirt_enabled() were possible "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:10 +0100
[PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:10 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check Juergen Gross <jgross@suse.com> - 2016-02-19 14:30 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-02-19 15:50 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-22 07:10 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check Borislav Petkov <bp@alien8.de> - 2016-02-22 11:30 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-22 15:40 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-23 00:20 +0100
Re: [Xen-devel] [PATCH 8/9] x86/rtc: replace paravirt_enabled() check with subarch check David Vrabel <david.vrabel@citrix.com> - 2016-02-19 14:30 +0100
[PATCH 5/9] apm32: remove paravirt_enabled() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:10 +0100
Re: [PATCH 5/9] apm32: remove paravirt_enabled() use Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-19 16:20 +0100
Re: [PATCH 5/9] apm32: remove paravirt_enabled() use "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 22:00 +0100
Re: [PATCH 5/9] apm32: remove paravirt_enabled() use Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-19 23:20 +0100
Re: [PATCH 5/9] apm32: remove paravirt_enabled() use "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-02-20 01:50 +0100
Re: [PATCH 5/9] apm32: remove paravirt_enabled() use Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2016-02-22 15:20 +0100
[PATCH 4/9] x86/init: make ebda depend on PC subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:20 +0100
[PATCH 1/9] x86/boot: enumerate documentation for the x86 hardware_subarch "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:20 +0100
Re: [Xen-devel] [PATCH 1/9] x86/boot: enumerate documentation for the x86 hardware_subarch Juergen Gross <jgross@suse.com> - 2016-02-19 14:30 +0100
Re: [Xen-devel] [PATCH 1/9] x86/boot: enumerate documentation for the x86 hardware_subarch David Vrabel <david.vrabel@citrix.com> - 2016-02-19 14:50 +0100
Re: [Xen-devel] [PATCH 1/9] x86/boot: enumerate documentation for the x86 hardware_subarch "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-02-19 15:50 +0100
[PATCH 6/9] x86/tboot: remove paravirt_enabled() "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:20 +0100
[PATCH 7/9] x86/cpu/intel: replace paravirt_enabled() for f00f work around "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:20 +0100
[PATCH 3/9] x86/xen: use X86_SUBARCH_XEN for PV guest boots "Luis R. Rodriguez" <mcgrof@kernel.org> - 2016-02-19 14:20 +0100
Re: [Xen-devel] [PATCH 0/9] x86/init: replace paravirt_enabled() were possible David Vrabel <david.vrabel@citrix.com> - 2016-02-19 14:40 +0100
Re: [Xen-devel] [PATCH 0/9] x86/init: replace paravirt_enabled() were possible "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-02-19 15:40 +0100
csiph-web