Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1339510

[PATCH 24/61] gpio: kempld: Use devm_gpiochip_add_data() for gpio registration

Path csiph.com!news.redatomik.org!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups linux.kernel
Subject [PATCH 24/61] gpio: kempld: Use devm_gpiochip_add_data() for gpio registration
Date Mon, 22 Feb 2016 15:30:02 +0100
Message-ID <r4ZES-741-9@gated-at.bofh.it> (permalink)
References <r4ZER-741-3@gated-at.bofh.it>
X-PGP-Universal processed; by hqnvupgp07.nvidia.com on Mon, 22 Feb 2016 06:22:46 -0800
X-Mailer git-send-email 2.1.4
MIME-Version 1.0
Content-Type text/plain
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 44
Organization linux.* mail to news gateway
X-Original-Cc <ldewangan@nvidia.com>, <bjorn.andersson@sonymobile.com>, <a.kesavan@samsung.com>, <gregkh@linuxfoundation.org>, <catalin.marinas@arm.com>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>, <bcm-kernel-feedback-list@broadcom.com>, <linux-arm-kernel@lists.infradead.org>, <linux-tegra@vger.kernel.org>
X-Original-Date Mon, 22 Feb 2016 19:38:13 +0530
X-Original-Message-ID <1456150130-2668-25-git-send-email-ldewangan@nvidia.com>
X-Original-References <1456150130-2668-1-git-send-email-ldewangan@nvidia.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1339510

Show key headers only | View raw


Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 drivers/gpio/gpio-kempld.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/drivers/gpio/gpio-kempld.c b/drivers/gpio/gpio-kempld.c
index 0111774..701f151 100644
--- a/drivers/gpio/gpio-kempld.c
+++ b/drivers/gpio/gpio-kempld.c
@@ -178,7 +178,7 @@ static int kempld_gpio_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	ret = gpiochip_add_data(chip, gpio);
+	ret = devm_gpiochip_add_data(dev, chip, gpio);
 	if (ret) {
 		dev_err(dev, "Could not register GPIO chip\n");
 		return ret;
@@ -190,20 +190,11 @@ static int kempld_gpio_probe(struct platform_device *pdev)
 	return 0;
 }
 
-static int kempld_gpio_remove(struct platform_device *pdev)
-{
-	struct kempld_gpio_data *gpio = platform_get_drvdata(pdev);
-
-	gpiochip_remove(&gpio->chip);
-	return 0;
-}
-
 static struct platform_driver kempld_gpio_driver = {
 	.driver = {
 		.name = "kempld-gpio",
 	},
 	.probe		= kempld_gpio_probe,
-	.remove		= kempld_gpio_remove,
 };
 
 module_platform_driver(kempld_gpio_driver);
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 24/61] gpio: kempld: Use devm_gpiochip_add_data() for gpio registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-22 15:30 +0100

csiph-web