[PATCH 37/61] gpio: rdc321x: Use devm_gpiochip_add_data() for gpio registration

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.freedyn.net!aioe.org!bofh.it!news.nic.it!robomod
From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	[PATCH 37/61] gpio: rdc321x: Use devm_gpiochip_add_data() for gpio registration
Date	Mon, 22 Feb 2016 15:30:02 +0100
Message-ID	<r4ZES-741-13@gated-at.bofh.it> (permalink)
References	<r4ZER-741-3@gated-at.bofh.it>
X-Original-To	<linus.walleij@linaro.org>, <gnurou@gmail.com>, <michael.hennerich@analog.com>, <corbet@lwn.net>, <albeu@free.fr>, <rjui@broadcom.com>, <shc_work@mail.ru>, <support.opensource@diasemi.com>, <swarren@wwwdotorg.org>, <thierry.reding@gmail.com>
X-PGP-Universal	processed; by hqnvupgp07.nvidia.com on Mon, 22 Feb 2016 06:24:05 -0800
X-Mailer	git-send-email 2.1.4
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	<ldewangan@nvidia.com>, <bjorn.andersson@sonymobile.com>, <a.kesavan@samsung.com>, <gregkh@linuxfoundation.org>, <catalin.marinas@arm.com>, <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>, <patches@opensource.wolfsonmicro.com>, <bcm-kernel-feedback-list@broadcom.com>, <linux-arm-kernel@lists.infradead.org>, <linux-tegra@vger.kernel.org>
X-Original-Date	Mon, 22 Feb 2016 19:38:26 +0530
X-Original-Message-ID	<1456150130-2668-38-git-send-email-ldewangan@nvidia.com>
X-Original-References	<1456150130-2668-1-git-send-email-ldewangan@nvidia.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1339513

Show key headers only | View raw

Use devm_gpiochip_add_data() for GPIO registration and remove the
need of driver callback .remove.

Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
 drivers/gpio/gpio-rdc321x.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/drivers/gpio/gpio-rdc321x.c b/drivers/gpio/gpio-rdc321x.c
index 96ddee3..ec945b9 100644
--- a/drivers/gpio/gpio-rdc321x.c
+++ b/drivers/gpio/gpio-rdc321x.c
@@ -194,23 +194,14 @@ static int rdc321x_gpio_probe(struct platform_device *pdev)
 
 	dev_info(&pdev->dev, "registering %d GPIOs\n",
 					rdc321x_gpio_dev->chip.ngpio);
-	return gpiochip_add_data(&rdc321x_gpio_dev->chip, rdc321x_gpio_dev);
-}
-
-static int rdc321x_gpio_remove(struct platform_device *pdev)
-{
-	struct rdc321x_gpio *rdc321x_gpio_dev = platform_get_drvdata(pdev);
-
-	gpiochip_remove(&rdc321x_gpio_dev->chip);
-
-	return 0;
+	return devm_gpiochip_add_data(&pdev->dev, &rdc321x_gpio_dev->chip,
+				      rdc321x_gpio_dev);
 }
 
 static struct platform_driver rdc321x_gpio_driver = {
 	.driver.name	= "rdc321x-gpio",
 	.driver.owner	= THIS_MODULE,
 	.probe		= rdc321x_gpio_probe,
-	.remove		= rdc321x_gpio_remove,
 };
 
 module_platform_driver(rdc321x_gpio_driver);
-- 
2.1.4

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 37/61] gpio: rdc321x: Use devm_gpiochip_add_data() for gpio registration Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-22 15:30 +0100

csiph-web