Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339392

Re: [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420

Show all headers | View raw

Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:

> On 19.02.2016 02:58, Punit Agrawal wrote:
>> Hi Krzysztof,
>> 
>> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
>> 
>>> On Exynos5420 we support 8 cpufreq steps (600-1300 MHz) for LITTLE and
>>> 12 steps for big core (700-1800 MHz). Add respective cooling cells.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>
>>> ---
>>>
>>> Changes since v1:
>>> 1. Add cooling properties to all CPUs (suggested by Viresh).
>>> ---
>>>  arch/arm/boot/dts/exynos5420-cpus.dtsi | 24 ++++++++++++++++++++++++
>>>  1 file changed, 24 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi
>>> index 261d25173f61..5c052d7ff554 100644
>>> --- a/arch/arm/boot/dts/exynos5420-cpus.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
>>> @@ -33,6 +33,9 @@
>>>  			clock-frequency = <1800000000>;
>>>  			cci-control-port = <&cci_control1>;
>>>  			operating-points-v2 = <&cluster_a15_opp_table>;
>>> +			cooling-min-level = <0>;
>>> +			cooling-max-level = <11>;
>> 
>> Although the above two properties are defined they aren't parsed in the
>> kernel.
>> 
>> Setting min / max extents for cooling devices via cooling maps does work
>> though.
>
> It is described as optional property in
> Documentation/devicetree/bindings/thermal/thermal.txt ... but indeed it
> is totally ignored.
>
> So what is the recommendation? Get rid of it from DTS and documentation
> or leave it because it will be implemented someday?

As long as you are not expecting any particular behaviour arising from
that property today I think it should be fine to leave it in.

Eduardo, do you agree?

>
> Thanks for feedback!
>
> Best regards,
> Krzysztof
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 06:20 +0100
  [PATCH v2 2/3] ARM: dts: Add cooling levels for CPUs on exynos5422/5800 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 06:20 +0100
    Re: [PATCH v2 2/3] ARM: dts: Add cooling levels for CPUs on  exynos5422/5800 Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-18 07:30 +0100
  [PATCH v2 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high  load Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 06:20 +0100
    Re: [PATCH v2 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on  high load Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-18 07:30 +0100
  Re: [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Punit Agrawal <punit.agrawal@arm.com> - 2016-02-18 19:00 +0100
    Re: [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 05:00 +0100
      Re: [PATCH v2 1/3] ARM: dts: Add cooling levels for CPUs on exynos5420 Punit Agrawal <punit.agrawal@arm.com> - 2016-02-22 12:30 +0100

csiph-web