Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example
Date	Mon, 22 Feb 2016 11:10:04 +0100
Message-ID	<r4VBi-42I-29@gated-at.bofh.it> (permalink)
References	<r4GsA-16v-41@gated-at.bofh.it> <r48TT-Dy-1@gated-at.bofh.it> <r4lR7-2q1-1@gated-at.bofh.it> <r4oFk-4B6-9@gated-at.bofh.it> <r4GsA-16v-43@gated-at.bofh.it> <r4GsA-16v-41@gated-at.bofh.it>
X-Original-To	SeongJae Park <sj38.park@gmail.com>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903
MIME-Version	1.0
Content-Type	text/plain; charset="us-ascii"
Content-ID	<26214.1456135273.1@warthog.procyon.org.uk>
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.22
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	14
X-Original-Cc	dhowells@redhat.com, Paul McKenney <paulmck@linux.vnet.ibm.com>, Jonathan Corbet <corbet@lwn.net>, linux-doc <linux-doc@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Mon, 22 Feb 2016 10:01:13 +0000
X-Original-Message-ID	<26215.1456135273@warthog.procyon.org.uk>
X-Original-References	<CAEjAshq=VxWQ8U=CqLJd96eR+07c-ZB5N7ed=kqoxKM9OpqPBA@mail.gmail.com> <1455948068-14221-1-git-send-email-sj38.park@gmail.com> <20160220195722.GG3522@linux.vnet.ibm.com> <CAEjAshoKMzz0C1pen=PkdcwR3=wJRn-XoxtBqw3PxeZn6SAuYg@mail.gmail.com> <20160221052542.GJ3522@linux.vnet.ibm.com> <CAEjAshq=VxWQ8U=CqLJd96eR+07c-ZB5N7ed=kqoxKM9OpqPBA@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1339310

Show key headers only | View raw

SeongJae Park <sj38.park@gmail.com> wrote:

>   a = 0;
>   /* Code that does not store to variable a. */
> + does_not_change_a();
>   a = 0;

Since it's not actually code that's meant to be executed, you could make it:

	a = 0;
	... code that does not store to variable a ...
	a = 0;

David

Thread

[PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-20 07:10 +0100
  Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-02-20 21:00 +0100
    Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-21 00:00 +0100
      Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-21 19:00 +0100
        Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example David Howells <dhowells@redhat.com> - 2016-02-22 11:10 +0100
          Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example SeongJae Park <sj38.park@gmail.com> - 2016-02-22 12:10 +0100
            Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example David Howells <dhowells@redhat.com> - 2016-02-22 12:20 +0100
              Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-02-22 17:40 +0100
                Re: [PATCH] Documentation/memory-barriers: fix wrong comment in example SeongJae Park <sj38.park@gmail.com> - 2016-02-22 22:50 +0100
      Re: [PATCH] Documentation/memory-barriers: fix wrong comment in  example "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2016-02-22 03:40 +0100

csiph-web