Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1339148

Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT

Show all headers | View raw

On Sun, Feb 21, 2016 at 09:32:13PM -0800, Bjorn Andersson wrote:
> On certain platforms (e.g. ARM64) the dma_ops needs to be explicitly set
> to be able to do DMA allocations, so use the of_dma_configure() helper
> to populate the dma properties and assign an appropriate dma_ops.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
>  drivers/usb/chipidea/core.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 7404064b9bbc..047b9d4e67aa 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -62,6 +62,7 @@
>  #include <linux/usb/chipidea.h>
>  #include <linux/usb/of.h>
>  #include <linux/of.h>
> +#include <linux/of_device.h>
>  #include <linux/phy.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/usb/ehci_def.h>
> @@ -834,6 +835,9 @@ struct platform_device *ci_hdrc_add_device(struct device *dev,
>  	pdev->dev.dma_parms = dev->dma_parms;
>  	dma_set_coherent_mask(&pdev->dev, dev->coherent_dma_mask);
>  
> +	if (IS_ENABLED(CONFIG_OF) && dev->of_node)
> +		of_dma_configure(&pdev->dev, dev->of_node);
> +
>  	ret = platform_device_add_resources(pdev, res, nres);
>  	if (ret)
>  		goto err;

Just would like to confirm, it will not affect the default behavior
which the "dma-ranges" is not set at those platforms?

-- 

Best Regards,
Peter Chen

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: chipidea: Configure DMA properties and ops from DT Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-22 06:40 +0100
  Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT Peter Chen <hzpeterchen@gmail.com> - 2016-02-22 07:10 +0100
    Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-22 07:20 +0100
  Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT Srinivas Kandagatla <srinivas.kandagatla@linaro.org> - 2016-02-22 11:10 +0100
    Re: [PATCH] usb: chipidea: Configure DMA properties and ops from DT Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-02-22 23:10 +0100

csiph-web