Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource
Date	2016-02-22 04:50 +0100
Message-ID	<r4PFw-7Zp-1@gated-at.bofh.it> (permalink)
References	<r4mDw-2VT-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Robert Jarzmik <robert.jarzmik@free.fr>
Date: Sat, 20 Feb 2016 21:45:26 +0100

> The dm9000 driver doesn't work in at least one device-tree
> configuration, spitting an error message on irq resource :
> [    1.062495] dm9000 8000000.ethernet: insufficient resources
> [    1.068439] dm9000 8000000.ethernet: not found (-2).
> [    1.073451] dm9000: probe of 8000000.ethernet failed with error -2
> 
> The reason behind is that the interrupt might be provided by a gpio
> controller, not probed when dm9000 is probed, and needing the probe
> deferral mechanism to apply.
> 
> Currently, the interrupt is directly taken from resources. This patch
> changes this to use the more generic platform_get_irq(), which handles
> the deferral.
> 
> Moreover, since commit Fixes: 7085a7401ba5 ("drivers: platform: parse
> IRQ flags from resources"), the interrupt trigger flags are honored in
> platform_get_irq(), so remove the needless code in dm9000.
> 
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Acked-by: Marcel Ziswiler <marcel@ziswiler.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3] net: ethernet: davicom: fix devicetree irq resource Robert Jarzmik <robert.jarzmik@free.fr> - 2016-02-20 21:50 +0100
  Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource Sergei Ianovich <ynvich@gmail.com> - 2016-02-22 02:00 +0100
  Re: [PATCH v3] net: ethernet: davicom: fix devicetree irq resource David Miller <davem@davemloft.net> - 2016-02-22 04:50 +0100

csiph-web