Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support

From	Charles Chiou <ch1102chiou@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support
Date	2016-02-22 03:40 +0100
Message-ID	<r4OzL-7aj-7@gated-at.bofh.it> (permalink)
References	<q4BY5-3Er-11@gated-at.bofh.it> <q4Dnc-5MW-21@gated-at.bofh.it> <qWfpw-28O-19@gated-at.bofh.it> <qYqgP-7X3-57@gated-at.bofh.it> <qYqAa-85u-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Oliver,
sure, we'll fix it at the next patch version. Thank you.
Charles

On 02/04/2016 07:37 PM, Oliver Neukum wrote:
> On Thu, 2016-02-04 at 19:22 +0800, Charles Chiou wrote:
>> +static int stex_choice_sleep_mic(pm_message_t state)
>> +{
>> +    switch (state.event) {
>> +    case PM_EVENT_SUSPEND:
>> +        return ST_S3;
>> +    case PM_EVENT_FREEZE:
>
> Why do you react to PM_EVENT_FREEZE at all?
> That is too early. You will get a HIBERNATE
> event anyway. If the write out fails you are
> in trouble if you already reacted to
> PM_EVENT_FREEZE
>
> 	Regards
> 		Oliver
>
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support Charles Chiou <ch1102chiou@gmail.com> - 2016-02-22 03:40 +0100

csiph-web