[PATCH] USB: idmouse.c: Put the interface on error

From	Junjie Mao <junjie.mao@enight.me>
Newsgroups	linux.kernel
Subject	[PATCH] USB: idmouse.c: Put the interface on error
Date	2016-02-22 04:00 +0100
Message-ID	<r4OT8-7hh-31@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

usb_autopm_put_interface() should be called regardless of what
idmouse_create_image() returns.

Signed-off-by: Junjie Mao <junjie.mao@enight.me>
---
 drivers/usb/misc/idmouse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/misc/idmouse.c b/drivers/usb/misc/idmouse.c
index 4e38683c653c..5105397e62fc 100644
--- a/drivers/usb/misc/idmouse.c
+++ b/drivers/usb/misc/idmouse.c
@@ -257,9 +257,9 @@ static int idmouse_open(struct inode *inode, struct file *file)
 		if (result)
 			goto error;
 		result = idmouse_create_image (dev);
+		usb_autopm_put_interface(interface);
 		if (result)
 			goto error;
-		usb_autopm_put_interface(interface);
 
 		/* increment our usage count for the driver */
 		++dev->open;
-- 
1.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] USB: idmouse.c: Put the interface on error Junjie Mao <junjie.mao@enight.me> - 2016-02-22 04:00 +0100

csiph-web