Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1339078
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Yong Wu <yong.wu@mediatek.com> |
| Newsgroups | linux.kernel |
| Subject | Re: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver |
| Date | Mon, 22 Feb 2016 03:50:02 +0100 |
| Message-ID | <r4OJs-7dG-7@gated-at.bofh.it> (permalink) |
| References | <r35Y6-3PR-3@gated-at.bofh.it> <r49PY-1my-5@gated-at.bofh.it> |
| X-Original-To | Guenter Roeck <linux@roeck-us.net> |
| Content-Type | text/plain; charset="UTF-8" |
| X-Mailer | Evolution 3.2.3-0ubuntu6 |
| Content-Transfer-Encoding | 7bit |
| MIME-Version | 1.0 |
| X-Mtk | N |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 43 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Joerg Roedel <joro@8bytes.org>, Thierry Reding <treding@nvidia.com>, Mark Rutland <mark.rutland@arm.com>, Matthias Brugger <matthias.bgg@gmail.com>, <p.zabel@pengutronix.de>, <devicetree@vger.kernel.org>, <pebolle@tiscali.nl>, <kendrick.hsu@mediatek.com>, <mitchelh@codeaurora.org>, <arnd@arndb.de>, <srv_heupstream@mediatek.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>, Tomasz Figa <tfiga@google.com>, <iommu@lists.linux-foundation.org>, Rob Herring <robh+dt@kernel.org>, Daniel Kurtz <djkurtz@google.com>, Sasha Hauer <kernel@pengutronix.de>, <linux-mediatek@lists.infradead.org>, <youhua.li@mediatek.com>, Robin Murphy <robin.murphy@arm.com>, <linux-arm-kernel@lists.infradead.org>, Lucas Stach <l.stach@pengutronix.de>, <djkurtz@chromium.org> |
| X-Original-Date | Mon, 22 Feb 2016 02:43:09 +0800 |
| X-Original-Message-ID | <1456080189.25237.4.camel@mhfsdcap03> |
| X-Original-References | <1455669974-1527-5-git-send-email-yong.wu@mediatek.com> <20160220070209.GA16577@roeck-us.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1339078 |
Show key headers only | View raw
On Fri, 2016-02-19 at 23:02 -0800, Guenter Roeck wrote:
> On Wed, Feb 17, 2016 at 08:46:13AM +0800, Yong Wu wrote:
> > This patch adds support for mediatek m4u (MultiMedia Memory Management
> > Unit).
[...]
> > +#include <linux/clk.h>
> > +#include <linux/component.h>
> > +#include <linux/dma-iommu.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/io.h>
> > +#include <linux/iommu.h>
> > +#include <linux/iopoll.h>
> > +#include <linux/list.h>
> > +#include <linux/module.h>
> > +#include <linux/of_address.h>
> > +#include <linux/of_iommu.h>
> > +#include <linux/of_irq.h>
> > +#include <linux/of_platform.h>
> > +#include <linux/platform_device.h>
> > +#include <soc/mediatek/smi.h>
> > +#include <dt-bindings/memory/mt8173-larb-port.h>
> > +
>
> Some missing includes:
>
> linux/bug.h
> for WARN_ON()
> linux/device.h
> for dev_xxx() error messages, dev_get_drvdata(), etc.
> linux/err.h
> for error functions (IS_ERR, error definitions)
> linux/slab.h
> for kzalloc() etc.
> linux/spinlock.h
> for spinlock functions
> asm/barrier.h
> for wmb()
>
> Guenter
Hi Guenter,
Thanks for this suggestion. I'm sorry that I didn't get any build
warning or error here. Anyway I will add them and send a quick v10.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH v9 4/5] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu <yong.wu@mediatek.com> - 2016-02-17 09:50 +0100
Re: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver Guenter Roeck <linux@roeck-us.net> - 2016-02-20 08:10 +0100
Re: [v9,4/5] iommu/mediatek: Add mt8173 IOMMU driver Yong Wu <yong.wu@mediatek.com> - 2016-02-22 03:50 +0100
csiph-web