Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1339019
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] Btrfs: ctree: added lines after variable declarations |
| Date | 2016-02-22 01:10 +0100 |
| Message-ID | <r4MeC-5Gm-11@gated-at.bofh.it> (permalink) |
| References | <r4LVf-5fA-11@gated-at.bofh.it> <r4M4W-5m8-7@gated-at.bofh.it> <r4MeC-5Gm-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, 2016-02-22 at 01:01 +0100, Philippe Loctaux wrote:
> Is there no need of additional blank line here particulary
> or in all lines that I changed?
Please don't top post and just here.
> On Sun, Feb 21, 2016 at 03:53:04PM -0800, Joe Perches wrote:
> > On Mon, 2016-02-22 at 00:46 +0100, Philippe Loctaux wrote:
> > > Added lines after variable declarations, fixing 22 checkpatch warnings.
> > []
> > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> > []
> > > @@ -4592,6 +4610,7 @@ void btrfs_truncate_item(struct btrfs_root *root, struct btrfs_path *path,
> > > data_end, old_data_start + new_size - data_end);
> > > } else {
> > > struct btrfs_disk_key disk_key;
> > > +
> > > u64 offset;
> >
> > Overzealous here.
> > No additional blank line required.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] Btrfs: ctree: added lines after variable declarations Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-22 00:50 +0100
Re: [PATCH] Btrfs: ctree: added lines after variable declarations Joe Perches <joe@perches.com> - 2016-02-22 01:00 +0100
Re: [PATCH] Btrfs: ctree: added lines after variable declarations Joe Perches <joe@perches.com> - 2016-02-22 01:10 +0100
Re: [PATCH] Btrfs: ctree: added lines after variable declarations Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-22 01:40 +0100
Re: [PATCH] Btrfs: ctree: added lines after variable declarations Joe Perches <joe@perches.com> - 2016-02-22 01:50 +0100
Re: [PATCH] Btrfs: ctree: added lines after variable declarations Philippe Loctaux <phil@philippeloctaux.com> - 2016-02-22 01:10 +0100
csiph-web