Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1338983
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis |
| Date | 2016-02-21 22:10 +0100 |
| Message-ID | <r4Jqq-3vP-19@gated-at.bofh.it> (permalink) |
| References | <r3z9L-7KJ-3@gated-at.bofh.it> <r3z9M-7KJ-15@gated-at.bofh.it> <r4J73-37v-3@gated-at.bofh.it> <r4Jqq-3vP-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 21/02/16 20:59, Joe Perches wrote:
> On Sun, 2016-02-21 at 20:41 +0000, Jonathan Cameron wrote:
>> On 18/02/16 15:53, Daniel Baluta wrote:
>>> This makes code consistent around inv_mpu6050 driver and
>>> fixes the following checkpatch.pl warning:
>>> CHECK: Alignment should match open parenthesis
>>>
>>> Note that there were few cases were it was not possible to
>>> fix this due to making the line too long, but we can live with that.
>>>
>>> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
>> Applied
> []
>>> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c
> []
>>> @@ -217,11 +217,10 @@ static int inv_mpu6050_sensor_show(struct inv_mpu6050_state *st, int reg,
>>> return IIO_VAL_INT;
>>> }
>>>
>>> -static int inv_mpu6050_read_raw(struct iio_dev *indio_dev,
>>> - struct iio_chan_spec const *chan,
>>> - int *val,
>>> - int *val2,
>>> - long mask) {
>>> +static int
>>> +inv_mpu6050_read_raw(struct iio_dev *indio_dev,
>>> + struct iio_chan_spec const *chan,
>>> + int *val, int *val2, long mask) {
>
> Ideally, you'd also convert this form to use
> the open brace on a new line like:
>
> static int
> inv_mpu6050_read_raw(struct iio_dev *indio_dev,
> struct iio_chan_spec const *chan,
> int *val, int *val2, long mask)
> {
>
Good point - as it fitted nicely in with Daniel's patch I applied a quick fixup
doing this one and the write_raw.
Thanks Joe,
Jonathan
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis Daniel Baluta <daniel.baluta@intel.com> - 2016-02-18 17:00 +0100
Re: [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis Jonathan Cameron <jic23@kernel.org> - 2016-02-21 21:50 +0100
Re: [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis Joe Perches <joe@perches.com> - 2016-02-21 22:10 +0100
Re: [RFC PATCH 7/9] iio: imu: inv_mpu6050: Fix alignment with open parenthesis Jonathan Cameron <jic23@kernel.org> - 2016-02-21 22:10 +0100
csiph-web