Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware()

From	Ming Lei <ming.lei@canonical.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware()
Date	2016-02-21 22:30 +0100
Message-ID	<r4JJM-3Ek-11@gated-at.bofh.it> (permalink)
References	<r4bRL-2PI-7@gated-at.bofh.it> <r4c1r-2TI-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Feb 20, 2016 at 5:22 PM, Sergey Senozhatsky
<sergey.senozhatsky@gmail.com> wrote:
> Set firmware_buf->size in fw_get_filesystem_firmware() after
> successful kernel_read_file_from_path(), otherwise assign_firmware_buf()
> fails.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>

Acked-by: Ming Lei <ming.lei@canonical.com>

This patch fixes d29a7309971afb97b21e7(firmware: replace call
to fw_read_file_contents() with kernel version).

thanks,

> ---
>  drivers/base/firmware_class.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index b8bc846..7cf41a5 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -335,6 +335,7 @@ static int fw_get_filesystem_firmware(struct device *device,
>                 }
>                 dev_dbg(device, "direct-loading %s\n",
>                         buf->fw_id);
> +               buf->size = size;
>                 fw_finish_direct_load(device, buf);
>                 break;
>         }
> --
> 2.7.1
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] firmware: set firmware_buf size in kernel_read_file_from_path() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-20 10:20 +0100
  Re: [PATCH] firmware: set firmware_buf size in  kernel_read_file_from_path() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-20 10:30 +0100
  [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-20 10:30 +0100
    Re: [PATCH] firmware: set firmware_buf size in  fw_get_filesystem_firmware() Sergey Senozhatsky <sergey.senozhatsky@gmail.com> - 2016-02-21 19:50 +0100
      Re: [PATCH] firmware: set firmware_buf size in  fw_get_filesystem_firmware() Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-21 20:00 +0100
    Re: [PATCH] firmware: set firmware_buf size in fw_get_filesystem_firmware() Ming Lei <ming.lei@canonical.com> - 2016-02-21 22:30 +0100

csiph-web