Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338940

Re: [PATCH v1 0/4] block: fix bio_will_gap()

Show all headers | View raw

> Hi Guys,
>
> The bio passed to bio_will_gap() may be fast cloned from upper
> layer(dm, md, bcache, fs, ...), or from bio splitting in block
> core. Unfortunately bio_will_gap() just figures out the last
> bvec via 'bi_io_vec[prev->bi_vcnt - 1]' directly, and this way
> is obviously wrong in case of fast-cloned bio.
>
> It is observed that lots of BIOs are still merged even if
> the virt boundary limit is violated by the merge, and the issue
> was reported from Sagi Grimberg.
>
> This patch introduces two helpers for getting the first and last
> bvec of one bio and applys them to fix the issue. Sagi tested
> the last patchset and confirmed the fix.
>
> V1:
> 	- get bvec directly for non-cloned bio
> 	- implement bio_get_last_bvec() with single bio_advance_iter(),
> 	and avoid to use bio_for_each_segment() which looks a bit inefficient
> 	- avoid to double check queue_virt_boundary() in bio_will_gap()

Thanks Ming,

Jens, can this make the next 4.5-rc since this regression was detected
in 4.5?

Thanks,
Sagi.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v1 0/4] block: fix bio_will_gap() Ming Lei <ming.lei@canonical.com> - 2016-02-19 04:30 +0100
  [PATCH v1 1/4] block: bio: introduce helpers to get the 1st and last bvec Ming Lei <ming.lei@canonical.com> - 2016-02-19 04:30 +0100
    Re: [PATCH v1 1/4] block: bio: introduce helpers to get the 1st and  last bvec Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-21 19:20 +0100
    Re: [PATCH v1 1/4] block: bio: introduce helpers to get the 1st and  last bvec Christoph Hellwig <hch@infradead.org> - 2016-02-22 10:00 +0100
  Re: [PATCH v1 0/4] block: fix bio_will_gap() Sagi Grimberg <sagig@dev.mellanox.co.il> - 2016-02-21 19:40 +0100

csiph-web