Re: [PATCH 2/2] mmc-sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection

From	Sascha Sommer <saschasommer@freenet.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] mmc-sdricoh_cs: Less checks in sdricoh_init_mmc() after, error detection
Date	2016-02-21 18:40 +0100
Message-ID	<r4G9c-XY-9@gated-at.bofh.it> (permalink)
References	<qEuGl-43C-5@gated-at.bofh.it> <qL9x8-5sz-15@gated-at.bofh.it> <qL9GN-5Lw-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

Am Tue, 29 Dec 2015 22:02:37 +0100
schrieb SF Markus Elfring <elfring@users.sourceforge.net>:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 29 Dec 2015 21:45:34 +0100
> 
> This issue was detected by using the Coccinelle software.
> 
> Two pointer checks could be repeated by the sdricoh_init_mmc()
> function during error handling even if the relevant properties can be
> determined for the involved variables before by source code analysis.
> 
> * This implementation detail could be improved by adjustments
>   for jump targets according to the Linux coding style convention.
> 
> * Drop an unnecessary initialisation for the variable "mmc" then.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---

Acked-by: Sascha Sommer <saschasommer@freenet.de>

Best regards

Sascha

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] mmc-sdricoh_cs: Less checks in sdricoh_init_mmc()  after, error detection Sascha Sommer <saschasommer@freenet.de> - 2016-02-21 18:40 +0100

csiph-web