Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338629

Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove

Show all headers | View raw

On Tuesday 16 February 2016 08:33 PM, Linus Walleij wrote:
> On Mon, Feb 15, 2016 at 2:17 PM, Laxman Dewangan <ldewangan@nvidia.com> wrote:
>
>> Add device managed APIs devm_gpiochip_add_data() and
>> devm_gpiochip_remove() for the APIs gpiochip_add_data()
>> and gpiochip_remove().
>>
>> This helps in reducing code in error path and sometimes
>> removal of .remove callback for driver unbind.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> I like the looks of this.
>
> One comment: you must also patch
> Documentation/driver-model/devres.txt

Sure,

>
> Will you also follow up with a massive patch set making use of
> this new API? I feel bad about merging an API if it's not used.
>
> Thanks for only supporting this for the new _data() function.
>
>
Yes, I have planned for this to use this new API. This is just for 
getting review whether fine or not to have devm_* APIs so that I can 
make changes on rest of driver to use this new APIs.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-15 14:30 +0100
  Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove Linus Walleij <linus.walleij@linaro.org> - 2016-02-16 16:10 +0100
    Re: [PATCH 1/1] gpio: add devm_ apis for gpio_chip_add and remove Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-20 05:20 +0100

csiph-web