Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338633

Re: [PATCH net] af_unix: Don't use continue to re-execute unix_stream_read_generic loop

Show all headers | View raw

From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Date: Thu, 18 Feb 2016 12:39:46 +0000

> The unix_stream_read_generic function tries to use a continue statement
> to restart the receive loop after waiting for a message. This may not
> work as intended as the caller might use a recvmsg call to peek at
> control messages without specifying a message buffer. If this was the
> case, the continue will cause the function to return without an error
> and without the credential information if the function had to wait for a
> message while it had returned with the credentials otherwise. Change to
> using goto to restart the loop without checking the condition first in
> this case so that credentials are returned either way.
> 
> Signed-off-by: Rainer Weikusat <rweikusat@mobileactivedefense.com>
> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net] af_unix: Don't use continue to re-execute unix_stream_read_generic loop Rainer Weikusat <rweikusat@mobileactivedefense.com> - 2016-02-18 13:50 +0100
  Re: [PATCH net] af_unix: Don't use continue to re-execute  unix_stream_read_generic loop David Miller <davem@davemloft.net> - 2016-02-20 06:00 +0100

csiph-web