Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337494

Re: [RESEND PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [RESEND PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps
Date 2016-02-18 17:20 +0100
Message-ID <r3zt9-88d-9@gated-at.bofh.it> (permalink)
References <qRfTc-p1-19@gated-at.bofh.it> <r3qpQ-1xV-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Alison Schofield <amsfield22@gmail.com>
Date: Wed, 17 Feb 2016 22:35:11 -0800

> divamnt stores a start_time at module init and uses it to calculate
> elapsed time. The elapsed time, stored in secs and usecs, is part of
> the trace data the driver maintains for the DIVA Server ISDN cards.
> No change to the format of that time data is required.
> 
> To avoid overflow on 32-bit systems use ktime_get_ts64() to return
> the elapsed monotonic time since system boot.
> 
> This is a change from real to monotonic time. Since the driver only
> stores elapsed time, monotonic time is sufficient and more robust
> against real time clock changes. These new monotonic values can be
> more useful for debugging because they can be easily compared to
> other monotonic timestamps.
> 
> Note elaspsed time values will now start at system boot time rather
> than module load time, so they will differ slightly from previously
> reported values.
> 
> Remove declaration and init of previously unused time constants:
> start_sec, start_usec.
> 
> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>

Applied to net-next, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[RESEND PATCH v3] isdn: divamnt: use y2038-safe ktime_get_ts64() for trace data timestamps Alison Schofield <amsfield22@gmail.com> - 2016-02-18 07:40 +0100
  Re: [RESEND PATCH v3] isdn: divamnt: use y2038-safe  ktime_get_ts64() for trace data timestamps David Miller <davem@davemloft.net> - 2016-02-18 17:20 +0100

csiph-web