Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1337364
| From | Rafał Miłecki <zajec5@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] b43: fix memory leak |
| Date | 2016-02-18 14:50 +0100 |
| Message-ID | <r3x7Y-6f7-9@gated-at.bofh.it> (permalink) |
| References | <r3w2d-5u1-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 18 February 2016 at 13:34, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > From: Sudip Mukherjee <sudip@vectorindia.org> > > On error we jumped to the label bcma_out and returned the error code but > we missed freeing dev. What if b43_one_core_attach fails? Won't we miss kfree then as well? Shouldn't you simply improve error path and maybe use an additional label? Also may we be missing a proper free in b43_bcma_remove as well? Your patch subject could also be a bit more descriptive (e.g. what memory leak exactly is it).
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] b43: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-18 13:40 +0100
Re: [PATCH] b43: fix memory leak Rafał Miłecki <zajec5@gmail.com> - 2016-02-18 14:50 +0100
Re: [PATCH] b43: fix memory leak Michael Büsch <m@bues.ch> - 2016-02-18 17:40 +0100
Re: [PATCH] b43: fix memory leak Kalle Valo <kvalo@codeaurora.org> - 2016-02-19 08:50 +0100
Re: [PATCH] b43: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-19 16:10 +0100
csiph-web