Re: [Linaro-acpi] [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi

From	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Newsgroups	linux.kernel
Subject	Re: [Linaro-acpi] [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi
Date	2016-02-18 14:20 +0100
Message-ID	<r3wEX-626-15@gated-at.bofh.it> (permalink)
References	<r2Oky-8F-5@gated-at.bofh.it> <r2Okz-8F-43@gated-at.bofh.it> <r3w2f-5u1-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 18, 2016 at 08:25:35PM +0800, liudongdong (C) wrote:

[...]

> >+/*
> >+ * Map a pci_mmcfg_region, can be overrriden by arch
> >+ */
> >+int __weak pci_mmconfig_map_resource(struct device *dev,
> >+	struct pci_mmcfg_region *mcfg)
> >+{
> >+	struct resource *tmp;
> >+	void __iomem *vaddr;
> >+
> >+	tmp = insert_resource_conflict(&iomem_resource, &mcfg->res);
> >+	if (tmp) {
> >+		dev_warn(dev, "MMCONFIG %pR conflicts with %s %pR\n",
> >+			&mcfg->res, tmp->name, tmp);
> >+		return -EBUSY;
> >+	}
> >+
> >+	vaddr =  ioremap(mcfg->res.start, resource_size(&mcfg->res));
               ^^
	       while at it, stray white space

> >+	if (!vaddr) {
> >+		release_resource(&mcfg->res);
> >+		return -ENOMEM;
> >+	}
> >+
> >+	mcfg->virt = vaddr;
> Here should be changed to
> 	mcfg->virt = vaddr - PCI_MMCFG_BUS_OFFSET(mcfg->start_bus);
> 
> or when pcie host "start_bus" is not 0, the configuraion access will be wrong.
Well spotted, thanks.

Lorenzo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to drivers/acpi Tomasz Nowicki <tn@semihalf.com> - 2016-02-16 15:00 +0100
  Re: [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list management to  drivers/acpi Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-02-17 12:00 +0100
  Re: [Linaro-acpi] [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list  management to drivers/acpi "liudongdong (C)" <liudongdong3@huawei.com> - 2016-02-18 13:40 +0100
    Re: [Linaro-acpi] [PATCH V5 01/15] ACPI: MCFG: Move mmcfg_list  management to drivers/acpi Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-02-18 14:20 +0100

csiph-web