Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337300

RE: [PATCH] Make core_pattern support namespace

From Zhao Lei <zhaolei@cn.fujitsu.com>
Newsgroups linux.kernel
Subject RE: [PATCH] Make core_pattern support namespace
Date 2016-02-18 13:10 +0100
Message-ID <r3vzd-5gf-35@gated-at.bofh.it> (permalink)
References <qYr3d-8vU-23@gated-at.bofh.it> <r2ONz-yV-13@gated-at.bofh.it> <r3gTw-36M-15@gated-at.bofh.it> <r3hmy-3j5-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi, Mateusz Guzik

> -----Original Message-----
> From: Mateusz Guzik [mailto:mguzik@redhat.com]
> Sent: Thursday, February 18, 2016 4:54 AM
> To: Eric W. Biederman <ebiederm@xmission.com>
> Cc: Zhao Lei <zhaolei@cn.fujitsu.com>; containers@lists.linux-foundation.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] Make core_pattern support namespace
> 
> On Wed, Feb 17, 2016 at 02:15:24PM -0600, Eric W. Biederman wrote:
> > Mateusz Guzik <mguzik@redhat.com> writes:
> > > On Tue, Feb 16, 2016 at 07:33:39PM +0800, Zhao Lei wrote:
> > >> For container based on namespace design, it is good to allow
> > >> each container keeping their own coredump setting.
> > >
> > > Sorry if this is a false alarm, I don't have easy means to test it, but
> > > is not this an immediate privilege escalation?
> >
> > It is.  This is why we do not currently have a per namespace setting.
> >
> 
> Thanks for confimation.
> 
> > Solving the user mode helper problem is technically a fair amount of
> > work, if not theoretically challenging.
> >
> 
> Well, I would say custom core_patterns without pipe support are still
> better than none.
> 
+1.

> Say one would ensure a stable core_pattern (i.e. that it cannot be
> modified as it is being parsed) and a restricted set of allowed
> characters in the pattern (which would not include the pipe), validated
> when one attempts to set the pattern.
> 
> Does this sound acceptable? If so, and there are no counter ideas from
> Lei, I can get around to that.
> 
If we can let kernel select pipe_program in vm's filesystem, and run
pipe_program with vm's filesystem, set a pipe for core_patterm in vm
will be safe.
What is your opinion on above solution?

If above way is not acceptable, or impossible to realize, I also
agree your solution of limit vm setting pipe.

Thanks
Zhaolei

> --
> Mateusz Guzik

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] Make core_pattern support namespace Mateusz Guzik <mguzik@redhat.com> - 2016-02-16 15:30 +0100
  Re: [PATCH] Make core_pattern support namespace ebiederm@xmission.com (Eric W. Biederman) - 2016-02-17 21:30 +0100
    Re: [PATCH] Make core_pattern support namespace Mateusz Guzik <mguzik@redhat.com> - 2016-02-17 22:00 +0100
      RE: [PATCH] Make core_pattern support namespace Zhao Lei <zhaolei@cn.fujitsu.com> - 2016-02-18 13:10 +0100
        Re: [PATCH] Make core_pattern support namespace ebiederm@xmission.com (Eric W. Biederman) - 2016-02-18 21:40 +0100
          RE: [PATCH] Make core_pattern support namespace Zhao Lei <zhaolei@cn.fujitsu.com> - 2016-02-19 11:30 +0100
  RE: [PATCH] Make core_pattern support namespace Zhao Lei <zhaolei@cn.fujitsu.com> - 2016-02-18 12:20 +0100

csiph-web