Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load

From	Marek Szyprowski <m.szyprowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load
Date	2016-02-18 11:00 +0100
Message-ID	<r3txp-3CY-23@gated-at.bofh.it> (permalink)
References	(1 earlier) <r34fE-2FN-11@gated-at.bofh.it> <r3gqv-2DK-13@gated-at.bofh.it> <r3lTc-6Da-19@gated-at.bofh.it> <r3mFA-7hh-19@gated-at.bofh.it> <r3oHo-fk-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello,

On 2016-02-18 05:42, Krzysztof Kozlowski wrote:
> On 18.02.2016 11:36, Viresh Kumar wrote:
>>> BTW, I found the issue. The order of trip points in DT:
>>> thermal_zone0/trip_point_0_hyst:5000
>>> thermal_zone0/trip_point_0_temp:50000
>>> thermal_zone0/trip_point_0_type:active
>>> thermal_zone0/trip_point_1_hyst:5000
>>> thermal_zone0/trip_point_1_temp:60000
>>> thermal_zone0/trip_point_1_type:active
>>> thermal_zone0/trip_point_2_hyst:5000
>>> thermal_zone0/trip_point_2_temp:70000
>>> thermal_zone0/trip_point_2_type:active
>>> thermal_zone0/trip_point_3_hyst:0
>>> thermal_zone0/trip_point_3_temp:120000	<---- this should be last one!
>>> thermal_zone0/trip_point_3_type:critical
>>> thermal_zone0/trip_point_4_hyst:5000
>>> thermal_zone0/trip_point_4_temp:90000
>>> thermal_zone0/trip_point_4_type:passive
>>> thermal_zone0/trip_point_5_hyst:5000
>>> thermal_zone0/trip_point_5_temp:110000
>>> thermal_zone0/trip_point_5_type:passive
>>>
>>> After fixing the order in DT, the cpu cooler starts working.
>> Ahh, nice.
> Damn, not entirely. I almost fried my Odroid (it survived 130 degrees of
> C)... The TMU supports only 4 trip points, so when I added two new trip
> points and reordered them... the last two (including critical) was not
> receiving interrupts.
>
> Polling mode is needed. I'll sent some patches soon...

Instead of polling the driver should simply use some dynamic window for
the nearest temperature ranges and reconfigure it when interrupt of occurs.

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland

Thread

[RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-17 08:00 +0100
  Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Anand Moon <linux.amoon@gmail.com> - 2016-02-17 21:00 +0100
    Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 02:50 +0100
      Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high  load Viresh Kumar <viresh.kumar@linaro.org> - 2016-02-18 03:40 +0100
        Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Anand Moon <linux.amoon@gmail.com> - 2016-02-18 04:00 +0100
        Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-18 05:50 +0100
          Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Marek Szyprowski <m.szyprowski@samsung.com> - 2016-02-18 11:00 +0100
            Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-19 01:00 +0100
      Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load Anand Moon <linux.amoon@gmail.com> - 2016-02-18 04:20 +0100

csiph-web