Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1337149

Re: [PATCHv2 0/4] Improve performance for SLAB_POISON

Show all headers | View raw

2016-02-16 3:44 GMT+09:00 Laura Abbott <labbott@fedoraproject.org>:
> Hi,
>
> This is a follow up to my previous series
> (http://lkml.kernel.org/g/<1453770913-32287-1-git-send-email-labbott@fedoraproject.org>)
> This series takes the suggestion of Christoph Lameter and only focuses on
> optimizing the slow path where the debug processing runs. The two main
> optimizations in this series are letting the consistency checks be skipped and
> relaxing the cmpxchg restrictions when we are not doing consistency checks.
> With hackbench -g 20 -l 1000 averaged over 100 runs:
>
> Before slub_debug=P
> mean 15.607
> variance .086
> stdev .294
>
> After slub_debug=P
> mean 10.836
> variance .155
> stdev .394
>
> This still isn't as fast as what is in grsecurity unfortunately so there's still
> work to be done. Profiling ___slab_alloc shows that 25-50% of time is spent in
> deactivate_slab. I haven't looked too closely to see if this is something that
> can be optimized.

There is something to be optimized. deactivate_slab() deactivate objects of
freelist one by one and it's useless. And, it deactivates freelist
with two phases.
Deactivating objects except last one and then deactivating last object with
node lock. It would be also optimized although I didn't think deeply.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv2 0/4] Improve performance for SLAB_POISON Laura Abbott <labbott@fedoraproject.org> - 2016-02-15 19:50 +0100
  [PATCHv2 2/4] slub: Fix/clean free_debug_processing return paths Laura Abbott <labbott@fedoraproject.org> - 2016-02-15 19:50 +0100
  [PATCHv2 4/4] slub: Relax CMPXCHG consistency restrictions Laura Abbott <labbott@fedoraproject.org> - 2016-02-15 19:50 +0100
  [PATCHv2 3/4] slub: Convert SLAB_DEBUG_FREE to SLAB_CONSISTENCY_CHECKS Laura Abbott <labbott@fedoraproject.org> - 2016-02-15 19:50 +0100
  [PATCHv2 1/4] slub: Drop lock at the end of free_debug_processing Laura Abbott <labbott@fedoraproject.org> - 2016-02-15 19:50 +0100
    Re: [PATCHv2 1/4] slub: Drop lock at the end of  free_debug_processing Christoph Lameter <cl@linux.com> - 2016-02-16 17:30 +0100
  Re: [PATCHv2 0/4] Improve performance for SLAB_POISON Joonsoo Kim <js1304@gmail.com> - 2016-02-18 09:40 +0100

csiph-web