Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110

From	Michał Kępień <kernel@kempniu.pl>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110
Date	2016-02-18 09:30 +0100
Message-ID	<r3s8k-2Pa-29@gated-at.bofh.it> (permalink)
References	(3 earlier) <r2PJE-1c4-9@gated-at.bofh.it> <r2VYJ-5w0-13@gated-at.bofh.it> <r38Mi-5Nt-33@gated-at.bofh.it> <r395F-6eW-43@gated-at.bofh.it> <r395F-6eW-47@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> > Please note that except for the first 5 entries, the keymap is sorted by
> > event code in ascending order.
> 
> I have prepared some patches which sort all event codes plus adds
> missing comments... So after all dell patches are in Darren tree, I will
> rewrite/rebase my and can send them.
> 
> > If I understand correctly, doing what you ask would break that ordering:
> > 
> >     /* Dell Instant Launch key */
> >     { KE_KEY, 0xe025, { KEY_PROG4 } },
> >     { KE_KEY, 0xe029, { KEY_PROG4 } },
> > 
> >     /* Audio panel key */
> >     { KE_IGNORE, 0xe026, { KEY_RESERVED } },
> > 
> > Is this acceptable?  Or perhaps you had something else on your mind?
> 
> Thats better, now we know which event is audio and which launch key.

Ok, then I will do that in v4.

-- 
Best regards,
Michał Kępień

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień <kernel@kempniu.pl> - 2016-02-16 16:00 +0100
  Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Pali Rohár <pali.rohar@gmail.com> - 2016-02-16 16:30 +0100
    Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień <kernel@kempniu.pl> - 2016-02-16 23:10 +0100
      Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Pali Rohár <pali.rohar@gmail.com> - 2016-02-17 12:50 +0100
        Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień <kernel@kempniu.pl> - 2016-02-17 13:10 +0100
          Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Pali Rohár <pali.rohar@gmail.com> - 2016-02-17 13:10 +0100
            Re: [PATCH v3 5/5] dell-wmi: support Dell Inspiron M5110 Michał Kępień <kernel@kempniu.pl> - 2016-02-18 09:30 +0100

csiph-web