Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336980

Re: [PATCH] staging: rtl8712: reduce stack usage

Show all headers | View raw

On 02/17/2016 02:32 AM, Arnd Bergmann wrote:
> The "translate_scan" function in rtl8712 uses a lot of stack, and
> gets inlined into its single caller, r8711_wx_get_scan, which
> in some configurations now blows the 1024 byte stack warning
> limit:
>
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In function 'r8711_wx_get_scan':
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c:1227:1: error: the frame size of 1032 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
>
> This somewhat reduces the stack usage by moving the translate_scan
> function out of line with the noinline_for_stack annotation.
> It might be possible to modify translate_scan() a little further
> to reduce the stack usage, but with this patch, we can build without
> the warning, the the call chain to get here is rather predictable
> (sys_ioctl->vfs_ioctl->sock_ioctl->dev_ioctl->wext_ioctl->
> r8711_wx_get_scan).
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>   drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

As there is no reason for translate_scan() to be inlined, this patch seems 
reasonable The largest user of stack likely comes from the line "struct iw_event 
iwe". Changing that to a pointer, and using kalloc to acquire the space would 
likely clear the compile message, but that would require many more changes.

Acked-by: Larry Finger <Larry.Finger@lwfinger.net>

Larry

>
> diff --git a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> index db2e31bcdd77..a15f3ce70223 100644
> --- a/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> +++ b/drivers/staging/rtl8712/rtl871x_ioctl_linux.c
> @@ -137,7 +137,7 @@ static inline void handle_group_key(struct ieee_param *param,
>   	}
>   }
>
> -static inline char *translate_scan(struct _adapter *padapter,
> +static noinline_for_stack char *translate_scan(struct _adapter *padapter,
>   				   struct iw_request_info *info,
>   				   struct wlan_network *pnetwork,
>   				   char *start, char *stop)
>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rtl8712: reduce stack usage Arnd Bergmann <arnd@arndb.de> - 2016-02-17 09:40 +0100
  Re: [PATCH] staging: rtl8712: reduce stack usage Larry Finger <Larry.Finger@lwfinger.net> - 2016-02-18 03:30 +0100
    Re: [PATCH] staging: rtl8712: reduce stack usage Arnd Bergmann <arnd@arndb.de> - 2016-02-18 10:30 +0100
  Re: [PATCH] staging: rtl8712: reduce stack usage Dan Carpenter <dan.carpenter@oracle.com> - 2016-02-19 11:20 +0100

csiph-web