Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support

From	Michael Welling <mwelling@ieee.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support
Date	2016-02-18 01:00 +0100
Message-ID	<r3kaK-5hs-11@gated-at.bofh.it> (permalink)
References	(5 earlier) <qZZvQ-19R-15@gated-at.bofh.it> <r0C4a-28R-5@gated-at.bofh.it> <r0Cxd-2iO-13@gated-at.bofh.it> <r0Ez0-3Nr-3@gated-at.bofh.it> <r0FY8-4CC-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Feb 10, 2016 at 10:36:22AM -0600, Michael Welling wrote:
> On Wed, Feb 10, 2016 at 08:39:04PM +0530, Sricharan wrote:
> > > Hi Sricharan,
> > > 
> > > Are you looking at pca9685_pwm_probe in drivers/pwm/pwm-pca9685.c
> > > right?
> > >
> >  Yes.
> >  
> > > I'm asking this because this driver doesn't seem to support runtime pm and
> > > there is no check for regmap_write/regmap_write return code in the probe
> > > function.
> >    Hmm to be clear, so it’s the pm_runtime_getsync from i2c-qup which fails right ?
> >    I was tracking that when there are i2c_xfers from pwm. I did not see any failures there.
> >    So wanted to know the correct sequence to reproduce.
> >
> 
> The problem was discovered using the patch that this thread is on. The PWM driver does
> not have the problem.
> 
> When the driver in this patch called pm_runtime_get_sync you got -EINVAL back.

I noticed some patches for the QUP I2C driver in linux-next so I built against it.

The ADC driver now appears to work as desired.

root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage0_raw 
287
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage1_raw 
269
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage2_raw 
270
root@dragonboard-410c:~# cat /sys/bus/iio/devices/iio\:device0/in_voltage3_raw 
271

> 
> > Regards,
> >   Sricharan
> >   
> > 
> >

Thread

RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support "Sricharan" <sricharan@codeaurora.org> - 2016-02-10 13:30 +0100
  Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Daniel Baluta <daniel.baluta@intel.com> - 2016-02-10 14:00 +0100
    RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support "Sricharan" <sricharan@codeaurora.org> - 2016-02-10 16:10 +0100
      Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-10 17:40 +0100
        Re: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support Michael Welling <mwelling@ieee.org> - 2016-02-18 01:00 +0100
          RE: [PATCH v4] iio: adc: Add TI ADS1015 ADC driver support "Sricharan" <sricharan@codeaurora.org> - 2016-02-18 09:50 +0100

csiph-web