Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1336808

Re: [PATCH v3 6/6] block: use dax_do_io() if blkdev_dax_capable()

Show all headers | View raw

On Wed, Feb 17, 2016 at 1:54 PM, Jan Kara <jack@suse.cz> wrote:
> On Tue 16-02-16 20:34:19, Ross Zwisler wrote:
>> From: Dan Williams <dan.j.williams@intel.com>
>>
>> Setting S_DAX on an inode requires that the inode participate in the
>> DAX-fsync mechanism which expects to use the pagecache for tracking
>> potentially dirty cpu cachelines.  However, dax_do_io() participates in
>> the standard pagecache sync semantics and arranges for dirty pages to be
>> flushed through the driver when a direct-IO operation accesses the same
>> ranges.
>>
>> It should always be valid to use the dax_do_io() path regardless of
>> whether the block_device inode has S_DAX set.  In either case dirty
>> pages or dirty cachelines are made durable before the direct-IO
>> operation proceeds.
>
> Please no. I agree that going via DAX path for normal likely won't
> introduce new data corruption issues. But I dislike having a special
> case for block devices. Also you have no way of turning DAX off for block
> devices AFAIU and as Dave said, DAX should be opt-in, not opt-out. Note
> that you may actually want to go through the block layer for normal IO e.g.
> because you use IO cgroups to limit processes so using DAX regresses some
> functionality.
>

Sounds good.

As Ross mentioned in the cover letter, I'm fine with dropping this one
for now as we think through how to restore raw device DAX support.  In
the meantime we can still force CONFIG_BLK_DEV_DAX=y for testing.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/6] DAX fixes, move flushing calls to FS Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-17 04:40 +0100
  [PATCH v3 4/6] dax: give DAX clearing code correct bdev Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-17 04:40 +0100
    Re: [PATCH v3 4/6] dax: give DAX clearing code correct bdev Jan Kara <jack@suse.cz> - 2016-02-17 22:40 +0100
  [PATCH v3 2/6] ext2, ext4: only set S_DAX for regular inodes Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-17 04:40 +0100
    Re: [PATCH v3 2/6] ext2, ext4: only set S_DAX for regular inodes Jan Kara <jack@suse.cz> - 2016-02-17 22:40 +0100
  [PATCH v3 1/6] block: disable block device DAX by default Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-17 04:40 +0100
    Re: [PATCH v3 1/6] block: disable block device DAX by default Jan Kara <jack@suse.cz> - 2016-02-17 23:00 +0100
  [PATCH v3 6/6] block: use dax_do_io() if blkdev_dax_capable() Ross Zwisler <ross.zwisler@linux.intel.com> - 2016-02-17 04:40 +0100
    Re: [PATCH v3 6/6] block: use dax_do_io() if blkdev_dax_capable() Jan Kara <jack@suse.cz> - 2016-02-17 23:00 +0100
      Re: [PATCH v3 6/6] block: use dax_do_io() if blkdev_dax_capable() Dan Williams <dan.j.williams@intel.com> - 2016-02-17 23:20 +0100

csiph-web