Re: [RESEND2 PATCH 1/3] memremap: add MEMREMAP_WC flag

From	Andrew Morton <akpm@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND2 PATCH 1/3] memremap: add MEMREMAP_WC flag
Date	2016-02-17 20:10 +0100
Message-ID	<r3fE6-2iW-9@gated-at.bofh.it> (permalink)
References	<qZXX3-8qz-11@gated-at.bofh.it> <qZXX4-8qz-27@gated-at.bofh.it> <r00ie-1J1-11@gated-at.bofh.it> <r0dIt-2Hb-7@gated-at.bofh.it> <r38VY-5U9-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 17 Feb 2016 11:53:48 +0000 Brian Starkey <brian.starkey@arm.com> wrote:

> Hi Andrew,
> 
> Would you pick these up if I rebase onto linux-next?

Sure.

> How strongly do you feel about the input argument modification vs.
> staying in-line with the rest of the function?

I see no reason why memremap() is modifying `flags' as it proceeds -
these flags are all disjoint so it's pointless.  I suggest you simply
take all that out in a preparatory patch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RESEND2 PATCH 1/3] memremap: add MEMREMAP_WC flag Brian Starkey <brian.starkey@arm.com> - 2016-02-09 11:30 +0100
  Re: [RESEND2 PATCH 1/3] memremap: add MEMREMAP_WC flag Brian Starkey <brian.starkey@arm.com> - 2016-02-17 13:00 +0100
    Re: [RESEND2 PATCH 1/3] memremap: add MEMREMAP_WC flag Andrew Morton <akpm@linux-foundation.org> - 2016-02-17 20:10 +0100

csiph-web