Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536
Date	2016-02-17 17:20 +0100
Message-ID	<r3cZB-oW-13@gated-at.bofh.it> (permalink)
References	<r2U6E-4e2-59@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, 16 Feb 2016, tchalamarla@caviumnetworks.com wrote:
> +#ifdef CONFIG_ARM64
> +/* Due to ERRATA#22536, ThunderX need to handle
> + * HOST_IRQ_STAT differently.
> + * Work around is to make sure all pending IRQs
> + * are served before leaving handler
> + */
> +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance)
> +{
> +	struct ata_host *host = dev_instance;
> +	struct ahci_host_priv *hpriv;
> +	unsigned int rc = 0;
> +	void __iomem *mmio;
> +	u32 irq_stat, irq_masked;
> +	unsigned int handled = 1;
> +
> +	VPRINTK("ENTER\n");

Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they
already track the enter/exit of interrupt handlers ....

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V3] AHCI: Workaround for ThunderX Errata#22536 <tchalamarla@caviumnetworks.com> - 2016-02-16 21:10 +0100
  Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536 Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 17:20 +0100

csiph-web