Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1338434

Re: [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver

Show all headers | View raw

Quoting Joshua Henderson (2016-02-19 08:25:35)
> +const struct clk_ops pic32_roclk_ops = {
> +       .enable                 = roclk_enable,
> +       .disable                = roclk_disable,
> +       .is_enabled             = roclk_is_enabled,
> +       .get_parent             = roclk_get_parent,
> +       .set_parent             = roclk_set_parent,
> +       .determine_rate         = roclk_determine_rate,
> +       .recalc_rate            = roclk_recalc_rate,
> +       .round_rate             = roclk_round_rate,
> +       .set_rate_and_parent    = roclk_set_rate_and_parent,
> +       .set_rate               = roclk_set_rate,
> +       .init                   = roclk_init,
> +};

You can remove .round_rate and only use .determine_rate.

...
> +CLK_OF_DECLARE(pic32mzda_clk, "microchip,pic32mzda-clk", pic32mzda_clock_init);

Can you make this a platform_driver instead of using CLK_OF_DECLARE? I
asked this in v6 but there was no response.

Regards,
Mike

> -- 
> 1.7.9.5
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v7 0/3] PIC32MZDA Clock Driver Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-19 17:30 +0100
  [PATCH v7 1/3] dt/bindings: Add PIC32 clock binding documentation Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-19 17:30 +0100
  [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-19 17:30 +0100
    Re: [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver Michael Turquette <mturquette@baylibre.com> - 2016-02-19 21:20 +0100
      Re: [PATCH v7 2/3] clk: clk-pic32: Add PIC32 clock driver Purna Chandra Mandal <purna.mandal@microchip.com> - 2016-02-20 08:10 +0100

csiph-web