Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1338406

Re: [PATCH] omap3: Add cpuidle parameters table for omap3430

From Tony Lindgren <tony@atomide.com>
Newsgroups linux.kernel
Subject Re: [PATCH] omap3: Add cpuidle parameters table for omap3430
Date 2016-02-19 19:40 +0100
Message-ID <r3Y8a-18c-5@gated-at.bofh.it> (permalink)
References <r2tg7-2PB-45@gated-at.bofh.it> <r2vKW-4Dk-19@gated-at.bofh.it> <r2KJX-6rY-9@gated-at.bofh.it> <r2KJY-6rY-37@gated-at.bofh.it> <r2Qmn-1Is-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


* Tony Lindgren <tony@atomide.com> [160216 08:11]:
> * Pali Rohár <pali.rohar@gmail.com> [160216 02:09]:
> > On Tuesday 16 February 2016 11:01:43 Daniel Lezcano wrote:
> > > On 02/15/2016 07:02 PM, Pali Rohár wrote:
> > > >Based on CPU type choose generic omap3 or omap3430 specific cpuidle
> > > >parameters. Parameters for omap3430 were measured on Nokia N900 device and
> > > >added by commit 5a1b1d3a9efa ("OMAP3: RX-51: Pass cpu idle parameters")
> > > >which were later removed by commit 231900afba52 ("ARM: OMAP3: cpuidle -
> > > >remove rx51 cpuidle parameters table") due to huge code complexity.
> > > >
> > > >This patch brings cpuidle parameters for omap3430 devices again, but uses
> > > >simple condition based on CPU type.
> > > >
> > > >Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> > > >Fixes: 231900afba52d6faddfb480cde4132d4edc089bc
> > > >---
> > > 
> > > Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > 
> > Tony, Nishanth (or somebody else...) can you test this patch on more
> > omap3 devices to check if it does not break existing cpuidle code?
> 
> Seems to work for me on a ldp, which is GP 3430 ES3.0.

OK applying this into omap-for-v4.6/fixes-not-urgent considering
we've already lived with it for years.

Regards,

Tony

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: Nokia N900: Proper C-states Tony Lindgren <tony@atomide.com> - 2016-02-09 17:00 +0100
  Re: Nokia N900: Proper C-states Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-09 18:10 +0100
    Re: Nokia N900: Proper C-states Pali Rohár <pali.rohar@gmail.com> - 2016-02-11 16:10 +0100
      Re: Nokia N900: Proper C-states Tony Lindgren <tony@atomide.com> - 2016-02-11 18:50 +0100
        Re: Nokia N900: Proper C-states Pali Rohár <pali.rohar@gmail.com> - 2016-02-15 11:20 +0100
          Re: Nokia N900: Proper C-states Tony Lindgren <tony@atomide.com> - 2016-02-15 16:30 +0100
            [PATCH] omap3: Add cpuidle parameters table for omap3430 Pali Rohár <pali.rohar@gmail.com> - 2016-02-15 19:10 +0100
              Re: [PATCH] omap3: Add cpuidle parameters table for omap3430 Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-02-16 11:10 +0100
                Re: [PATCH] omap3: Add cpuidle parameters table for omap3430 Pali Rohár <pali.rohar@gmail.com> - 2016-02-16 11:10 +0100
                Re: [PATCH] omap3: Add cpuidle parameters table for omap3430 Tony Lindgren <tony@atomide.com> - 2016-02-16 17:10 +0100
                Re: [PATCH] omap3: Add cpuidle parameters table for omap3430 Tony Lindgren <tony@atomide.com> - 2016-02-19 19:40 +0100
      Re: Nokia N900: Proper C-states Pali Rohár <pali.rohar@gmail.com> - 2016-02-15 11:20 +0100

csiph-web