Re: [RFC PATCH 12/20] PKCS#7: Make the signature a pointer rather than embedding it [ver #2]

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 12/20] PKCS#7: Make the signature a pointer rather than embedding it [ver #2]
Date	2016-02-19 13:00 +0100
Message-ID	<r3RT5-4A8-35@gated-at.bofh.it> (permalink)
References	<qZSNI-50Q-13@gated-at.bofh.it> <qSCNI-78i-3@gated-at.bofh.it> <qSCNI-78i-13@gated-at.bofh.it> <qZSNI-50Q-13@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> > Point to the public_key_signature struct from the pkcs7_signed_info struct
> > rather than embedding it.  This makes it easier to have it take an
> > arbitrary number of MPIs in future.
> 
> Just a reminder ...
> 
> Reviewing patches isn't easy no matter how well written and documented,
> especially large patch sets.   For this reason, patch sets should be
> limited to the patches that are required to accomplish the patch set
> goal.  In this case, that goal is to change  "how certificates/keys are
> determined to be trusted."
> 
> Although this patch is straight forward, the patch description should
> include a reason for including this patch in this patch set.   Is having
> an arbitrary number of MPIs included in this patch set?  Could this
> patch be deferred?

Actually, this may be changed with the advent of Tadeusz's patches.

David

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [RFC PATCH 12/20] PKCS#7: Make the signature a pointer rather than embedding it [ver #2] David Howells <dhowells@redhat.com> - 2016-02-19 13:00 +0100

csiph-web