Re: [PATCH next] ARM: virt: fix build of hyp-stub

From	Jean-Philippe Brucker <Jean-Philippe.Brucker@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH next] ARM: virt: fix build of hyp-stub
Date	2016-02-19 11:20 +0100
Message-ID	<r3Qki-3vx-11@gated-at.bofh.it> (permalink)
References	<r3GkV-4AB-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Vincent,

On Fri, Feb 19, 2016 at 12:31:17AM +0100, Vincent Stehlé wrote:
> Compile hyp-stub explicitly for arm v7-a. This fixes the following build
> errors:
> 
>   arch/arm/kernel/hyp-stub.S: Assembler messages:
>   arch/arm/kernel/hyp-stub.S:168: Error: selected processor does not support `ubfx r7,r7,#28,#4' in ARM mode
>   arch/arm/kernel/hyp-stub.S:176: Error: selected processor does not support `isb' in ARM mode
> 
> Signed-off-by: Vincent Stehlé <vincent.stehle@laposte.net>
> Cc: Jean-Philippe Brucker <jean-philippe.brucker@arm.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Russell King <rmk+kernel@arm.linux.org.uk>
> ---
> 
> 
> Hi,
> 
> This can be seen with linux next-20160218 and arm e.g. allmodconfig.

Thanks for doing this. I just posted my fix to the patch system, before
seeing yours (it also requires change in boot/compressed/Makefile -
hyp-stub is built twice). See the previous discussion about this issue
here: http://thread.gmane.org/gmane.linux.ports.arm.kernel/479256

Thanks,
Jean-Philippe

> 
> Best regards,
> 
> V.
> 
> 
>  arch/arm/kernel/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/kernel/Makefile b/arch/arm/kernel/Makefile
> index 2c5f160..15684c5 100644
> --- a/arch/arm/kernel/Makefile
> +++ b/arch/arm/kernel/Makefile
> @@ -88,6 +88,8 @@ obj-$(CONFIG_DEBUG_LL)	+= debug.o
>  obj-$(CONFIG_EARLY_PRINTK)	+= early_printk.o
>  
>  obj-$(CONFIG_ARM_VIRT_EXT)	+= hyp-stub.o
> +AFLAGS_hyp-stub.o		:=-Wa,-march=armv7-a
> +
>  ifeq ($(CONFIG_ARM_PSCI),y)
>  obj-$(CONFIG_SMP)		+= psci_smp.o
>  endif
> -- 
> 2.7.0
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH next] ARM: virt: fix build of hyp-stub Vincent Stehlé <vincent.stehle@laposte.net> - 2016-02-19 00:40 +0100
  Re: [PATCH next] ARM: virt: fix build of hyp-stub Jean-Philippe Brucker <Jean-Philippe.Brucker@arm.com> - 2016-02-19 11:20 +0100

csiph-web