Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1338012
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] gpio: pisosr: add missing unlock |
| Date | 2016-02-19 10:30 +0100 |
| Message-ID | <r3PxU-2Sp-11@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
If spi_read() fails then we just returned but we missed unlocking the mutex. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> --- drivers/gpio/gpio-pisosr.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index 58ea08d..f9f1074 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -53,12 +53,10 @@ static int pisosr_gpio_refresh(struct pisosr_gpio *gpio) } ret = spi_read(gpio->spi, gpio->buffer, gpio->buffer_size); - if (ret) - return ret; mutex_unlock(&gpio->lock); - return 0; + return ret; } static int pisosr_gpio_get_direction(struct gpio_chip *chip, -- 1.9.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] gpio: pisosr: add missing unlock Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-19 10:30 +0100 Re: [PATCH] gpio: pisosr: add missing unlock Linus Walleij <linus.walleij@linaro.org> - 2016-02-19 13:00 +0100
csiph-web