Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data
Date	2016-02-19 09:50 +0100
Message-ID	<r3OVd-2o2-25@gated-at.bofh.it> (permalink)
References	(4 earlier) <r3iiD-3Xr-31@gated-at.bofh.it> <r3iBY-4nq-13@gated-at.bofh.it> <r3rYB-2K0-13@gated-at.bofh.it> <r3u0s-44o-61@gated-at.bofh.it> <r3utt-4hK-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 18 Feb 2016, Thomas Gleixner wrote:
> So there is a limitation to BIOS creativity and all we need is to maintain a
> logical package id.

Just for the record. This driver would fall apart today if the socket ids
would be > 7. The uncore extra PCI devs assume a fixed mapping between the
physid in their config space and the physid of the socket. If the pci config
space id would be > 8 then the storage space is exceeded.

#define UNCORE_SOCKET_MAX               8
struct pci_dev *uncore_extra_pci_dev[UNCORE_SOCKET_MAX][UNCORE_EXTRA_PCI_DEV_MAX];

Of course there is no range check for this either. uncore_pci_probe() sticks
it blindly into the array....

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 14:50 +0100
  Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Stephane Eranian <eranian@google.com> - 2016-02-17 22:20 +0100
    Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 22:30 +0100
    Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Andi Kleen <andi@firstfloor.org> - 2016-02-17 22:30 +0100
      Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 23:00 +0100
        Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Andi Kleen <andi@firstfloor.org> - 2016-02-17 23:20 +0100
          Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-17 23:40 +0100
          Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Ingo Molnar <mingo@kernel.org> - 2016-02-18 09:00 +0100
          Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Peter Zijlstra <peterz@infradead.org> - 2016-02-18 09:20 +0100
            Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Stephane Eranian <eranian@google.com> - 2016-02-18 10:40 +0100
              Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Peter Zijlstra <peterz@infradead.org> - 2016-02-18 11:00 +0100
              Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-18 11:30 +0100
            Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-18 11:30 +0100
              Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-18 12:00 +0100
                Re: [patch 07/11] x86/perf/uncore: Track packages not per cpu data Thomas Gleixner <tglx@linutronix.de> - 2016-02-19 09:50 +0100

csiph-web