Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1337868
| From | Ben Skeggs <skeggsb@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/3] drm/nouveau: use post-decrement in error handling |
| Date | 2016-02-19 04:40 +0100 |
| Message-ID | <r3K5c-7iH-1@gated-at.bofh.it> (permalink) |
| References | <r2wnE-4Wo-15@gated-at.bofh.it> <r2wnE-4Wo-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On 02/16/2016 04:41 AM, Rasmus Villemoes wrote:
> We need to use post-decrement to get the dma_map_page undone also for
> i==0, and to avoid some very unpleasant behaviour if dma_map_page
> failed already at i==0.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Ben Skeggs <bskeggs@redhat.com>
> ---
> drivers/gpu/drm/nouveau/nouveau_bo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c
> index 78f520d05de9..e3acc35e3805 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_bo.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c
> @@ -1520,7 +1520,7 @@ nouveau_ttm_tt_populate(struct ttm_tt *ttm)
> DMA_BIDIRECTIONAL);
>
> if (dma_mapping_error(pdev, addr)) {
> - while (--i) {
> + while (i--) {
> dma_unmap_page(pdev, ttm_dma->dma_address[i],
> PAGE_SIZE, DMA_BIDIRECTIONAL);
> ttm_dma->dma_address[i] = 0;
>
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 2/3] drm/nouveau: use post-decrement in error handling Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2016-02-15 19:50 +0100 Re: [PATCH 2/3] drm/nouveau: use post-decrement in error handling Ben Skeggs <skeggsb@gmail.com> - 2016-02-19 04:40 +0100
csiph-web