Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter

From	Antony Pavlov <antonynpavlov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter
Date	2016-02-18 22:50 +0100
Message-ID	<r3ECu-3kv-9@gated-at.bofh.it> (permalink)
References	<r0bGG-1oa-11@gated-at.bofh.it> <r3zt9-88d-13@gated-at.bofh.it> <r3ASe-CA-5@gated-at.bofh.it> <r3BEC-1ga-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 18 Feb 2016 21:31:20 +0300
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:

> On 02/18/2016 09:06 PM, Antony Pavlov wrote:
[...]
> > so I use regulator in the TL-MR3020 board dts file:
> >
> >          reg_usb_vbus: reg_usb_vbus {
> >                  compatible = "regulator-fixed";
> >                  regulator-name = "usb_vbus";
> >                  regulator-min-microvolt = <5000000>;
> 
>     Not 0?
> 
> >                  regulator-max-microvolt = <5000000>;
> >                  gpio = <&gpio 8 GPIO_ACTIVE_HIGH>;
> 
>     Where's the switch if both voltages are equal?

Here is a quote from linux/Documentation/devicetree/bindings/regulator/fixed-regulator.txt

        Any property defined as part of the core regulator
        binding, defined in regulator.txt, can also be used.
        However a fixed voltage regulator is expected to have the
        regulator-min-microvolt and regulator-max-microvolt
        to be the same.

Moreover please see this of_get_fixed_voltage_config() code fragment
(please see linux/drivers/regulator/fixed.c for details):

	if (init_data->constraints.min_uV == init_data->constraints.max_uV) {
		config->microvolts = init_data->constraints.min_uV;
	} else {
		dev_err(dev,
			 "Fixed regulator specified with variable voltages\n");
		return ERR_PTR(-EINVAL);
	}

-- 
Best regards,
  Antony Pavlov

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter Alan Stern <stern@rowland.harvard.edu> - 2016-02-18 17:20 +0100
  Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter Marek Vasut <marex@denx.de> - 2016-02-18 17:40 +0100
  Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter Antony Pavlov <antonynpavlov@gmail.com> - 2016-02-18 18:50 +0100
    Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-18 19:40 +0100
      Re: [RFC v5 07/15] usb: ehci: add vbus-gpio parameter Antony Pavlov <antonynpavlov@gmail.com> - 2016-02-18 22:50 +0100

csiph-web