Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1337726

Re: [PATCH] net: fix bridge multicast packet checksum validation

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] net: fix bridge multicast packet checksum validation
Date 2016-02-18 21:40 +0100
Message-ID <r3DwK-2Fr-15@gated-at.bofh.it> (permalink)
References <r2gVA-2Vi-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Linus Lüssing <linus.luessing@c0d3.blue>
Date: Mon, 15 Feb 2016 03:07:06 +0100

> @@ -4084,10 +4089,22 @@ struct sk_buff *skb_checksum_trimmed(struct sk_buff *skb,
>  	if (!pskb_may_pull(skb_chk, offset))
>  		goto err;
>  
> -	__skb_pull(skb_chk, offset);
> +	ip_summed = skb->ip_summed;
> +	csum_valid = skb->csum_valid;
> +	csum_level = skb->csum_level;
> +	csum_bad = skb->csum_bad;
> +	csum = skb->csum;
> +
> +	skb_pull_rcsum(skb_chk, offset);
>  	ret = skb_chkf(skb_chk);
>  	__skb_push(skb_chk, offset);
>  
> +	skb->ip_summed = ip_summed;
> +	skb->csum_valid = csum_valid;
> +	skb->csum_level = csum_level;
> +	skb->csum_bad = csum_bad;
> +	skb->csum = csum;
> +

There really has to be a better way to fix this :-/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: fix bridge multicast packet checksum validation Linus Lüssing <linus.luessing@c0d3.blue> - 2016-02-15 03:20 +0100
  Re: [PATCH] net: fix bridge multicast packet checksum validation "Steinar H. Gunderson" <sgunderson@bigfoot.com> - 2016-02-18 14:00 +0100
    Re: [PATCH] net: fix bridge multicast packet checksum validation Linus Lüssing <linus.luessing@c0d3.blue> - 2016-02-18 14:40 +0100
  Re: [PATCH] net: fix bridge multicast packet checksum validation David Miller <davem@davemloft.net> - 2016-02-18 21:40 +0100
    Re: [PATCH] net: fix bridge multicast packet checksum validation Stephen Hemminger <stephen@networkplumber.org> - 2016-02-19 02:40 +0100

csiph-web