Re: [net PATCH] IFF_NO_QUEUE: Fix for drivers not calling ether_setup()

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [net PATCH] IFF_NO_QUEUE: Fix for drivers not calling ether_setup()
Date	2016-02-18 21:00 +0100
Message-ID	<r3CU3-27a-21@gated-at.bofh.it> (permalink)
References	<r3aO7-7aS-35@gated-at.bofh.it> <r3bqN-7FR-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Phil Sutter <phil@nwl.cc>
Date: Wed, 17 Feb 2016 15:37:43 +0100

> My implementation around IFF_NO_QUEUE driver flag assumed that leaving
> tx_queue_len untouched (specifically: not setting it to zero) by drivers
> would make it possible to assign a regular qdisc to them without having
> to worry about setting tx_queue_len to a useful value. This was only
> partially true: I overlooked that some drivers don't call ether_setup()
> and therefore not initialize tx_queue_len to the default value of 1000.
> Consequently, removing the workarounds in place for that case in qdisc
> implementations which cared about it (namely, pfifo, bfifo, gred, htb,
> plug and sfb) leads to problems with these specific interface types and
> qdiscs.
> 
> Luckily, there's already a sanitization point for drivers setting
> tx_queue_len to zero, which can be reused to assign the fallback value
> most qdisc implementations used, which is 1.
> 
> Fixes: 348e3435cbefa ("net: sched: drop all special handling of tx_queue_len == 0")
> Tested-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> Signed-off-by: Phil Sutter <phil@nwl.cc>

Applied and queued up for -stable, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Revert "net: sched: drop all special handling of tx_queue_len == 0" Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-02-17 02:00 +0100
  Re: [PATCH] Revert "net: sched: drop all special handling of  tx_queue_len == 0" Phil Sutter <phil@nwl.cc> - 2016-02-17 14:00 +0100
    Re: [PATCH] Revert "net: sched: drop all special handling of  tx_queue_len == 0" Phil Sutter <phil@nwl.cc> - 2016-02-17 15:00 +0100
    Re: [PATCH] Revert "net: sched: drop all special handling of  tx_queue_len == 0" Mathieu Desnoyers <mathieu.desnoyers@efficios.com> - 2016-02-17 15:00 +0100
      [net PATCH] IFF_NO_QUEUE: Fix for drivers not calling ether_setup() Phil Sutter <phil@nwl.cc> - 2016-02-17 15:40 +0100
        Re: [net PATCH] IFF_NO_QUEUE: Fix for drivers not calling  ether_setup() David Miller <davem@davemloft.net> - 2016-02-18 21:00 +0100

csiph-web